Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2174098imu; Fri, 14 Dec 2018 06:58:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/VGMxqpf+R8kkQ9jMF4c8XRV+YYGP551InJZl31JstfmqzIzJgPEwM1oVCzId+DG6ILyCn3 X-Received: by 2002:a17:902:7402:: with SMTP id g2mr3097682pll.198.1544799494371; Fri, 14 Dec 2018 06:58:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544799494; cv=none; d=google.com; s=arc-20160816; b=WgTraly8l3BIPXsKOJZyf0HuFxpxMQQ+JjHBkDMLzZPhtjdhVgwROyUrdEFJ0sVeV9 npMbVo3IcagWUyuK1i28dt4giWI2+HJAsLd3V+l+TDeoBaL1gQ9LPVW28E8n/cgQhhm5 GXp6JPIi/vh9e8XphvxadhFKJslpfrDT/gVfVWXOFE2KOp21qWOQm1nGXZOL+WhdDWK7 UJBEvr8OO91+SFYpOyNrjOZH6La1Sh8dCLx9GE6JHiytgQ+pLoGThOjiaIXnN2ksDdAy dN07DfD6pjkbtIIXPe+FLgmVe1sNKYBkbvt8QAEwM7is4dsb6X/4HMBPoANPIOQuUlG3 NWNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HwIxwNGGDwTYkzfkitAN4J/heIowJ/YsbzhBDSG4UnY=; b=YfXXccSgwbEoANnPAi2G8O6ExlXWF//snea9BDl/sscjOKknQf99ufWOvrAhmKwtwM uGfnAAJePjK4g+oH8gDIQFXq3m0RJGymqM3wVRnzZqCwYyw0IbpBFkLLvpKWY9D6uxDd /OavkvoEkxFbQWKPHpmwN7x+1KBGSkEwFOj62xSiLvZv9Jmg3BidBDrmZ/vQ4jdsxkWU jztD4HcxUSrfaeAX3TsgbbRAOs66N+6yLJbvLfEhx7xuYofecm0+222qcf4dEUWiE2Yd eKckcDEKbFbhZoFl50P1cAGn2elytgbzLKfpkglKGBlXxneMCIOrvdWXK5bBluQXdziw i7LQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b70si4428324pfe.168.2018.12.14.06.57.57; Fri, 14 Dec 2018 06:58:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730212AbeLNO4w (ORCPT + 99 others); Fri, 14 Dec 2018 09:56:52 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:52542 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729710AbeLNO4v (ORCPT ); Fri, 14 Dec 2018 09:56:51 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gXotM-0003Tk-JH; Fri, 14 Dec 2018 22:56:40 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gXotE-0001d2-TW; Fri, 14 Dec 2018 22:56:32 +0800 Date: Fri, 14 Dec 2018 22:56:32 +0800 From: Herbert Xu To: Florian Westphal Cc: Wolfgang Walter , David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, steffen.klassert@secunet.com, christophe.gouault@6wind.com Subject: Re: INFO: rcu detected stall in xfrm_hash_rebuild Message-ID: <20181214145632.urh3n4vua66wvmkx@gondor.apana.org.au> References: <00000000000075fe86057ca6367e@google.com> <20181210124724.iuver2va3yjdsokf@breakpoint.cc> <20181210.095856.580441946779980596.davem@davemloft.net> <2559562.n5nkmlqv4s@stwm.de> <20181214143532.43zgy2hwkdskwfn2@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181214143532.43zgy2hwkdskwfn2@breakpoint.cc> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2018 at 03:35:32PM +0100, Florian Westphal wrote: > > Ok. An alternative would be to remove the support for > policy hash table thresholds (which decide what kinds of policies > go to exact table and which ones go into inexact ones), i.e. > partially revert 880a6fab8f6ba5b5abe59ea6 > ("xfrm: configure policy hash table thresholds by netlink"). > > This would remove the need for the rehashing support that > re-sorts the policies into either exact/inexact lists) when the > those tunables are changed. > > We could also easily convert the exact table to an rhashtable > then if we wanted to. We could also do both. In fact that was the reason why I started working on rhashtable in the first place. The idea is to extend the run-time rehashing to include both parts of the database. So you would look up the old table/list combo and then move onto the new one. Of course I never had time to finish this and I think the entity asking for this has moved onto something else. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt