Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com>
Subject: Re: [PATCH] checkpatch: add Co-Developed-by to signature tags
From:   Joe Perches <joe@perches.com>
To:     Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
        apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, niklas.cassel@linaro.org
Date:   Fri, 14 Dec 2018 07:52:15 -0800
In-Reply-To: <1544792494-15485-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
References: <1544792494-15485-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-12-14 at 14:01 +0100, Jorge Ramirez-Ortiz wrote:
> As per Documentation/process/submitting-patches, Co-developed-by is a
> valid signature.
> 
> This commit removes the warning.

Your commit message doesn't match your subject.

A couple variants have been documented and only
one should actually be used.

$ git grep -i co-developed-by Documentation/process/
Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer

$ git log --grep="co-developed-by:" -i | \
  grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn
     80 Co-developed-by:
     40 Co-Developed-by:

So which should it be?

btw: I prefer neither as I think Signed-off-by: is sufficient.

> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -468,6 +468,7 @@ our $logFunctions = qr{(?x:
>  
>  our $signature_tags = qr{(?xi:
>  	Signed-off-by:|
> +	Co-Developed-by:|
>  	Acked-by:|
>  	Tested-by:|
>  	Reviewed-by:|