Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] checkpatch: add Co-Developed-by to signature tags
To:     Joe Perches <joe@perches.com>, apw@canonical.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, niklas.cassel@linaro.org
References: <1544792494-15485-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com>
From:   Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Message-ID: <1b4cdda0-9ffb-52b8-6a13-be9eb079bab5@linaro.org>
Date:   Fri, 14 Dec 2018 17:03:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/14/18 16:52, Joe Perches wrote:

>
> A couple variants have been documented and only
> one should actually be used.
>
> $ git grep -i co-developed-by Documentation/process/
> Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
> Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
> Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer
>
> $ git log --grep="co-developed-by:" -i | \
>    grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn
>       80 Co-developed-by:
>       40 Co-Developed-by:
>
> So which should it be?
>
> btw: I prefer neither as I think Signed-off-by: is sufficient

IMO neither is only an option if you comfortable with the script 
generating false warnings.

If you wont apply the patch anyway I wont pursue it further.
Otherwise please let me know I will also update the documentation to 
match the commit.

TIA


> .
>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -468,6 +468,7 @@ our $logFunctions = qr{(?x:
>>   
>>   our $signature_tags = qr{(?xi:
>>   	Signed-off-by:|
>> +	Co-Developed-by:|
>>   	Acked-by:|
>>   	Tested-by:|
>>   	Reviewed-by:|
>