Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181214141433.466991-1-liuxiaozhou@bytedance.com>
In-Reply-To: <20181214141433.466991-1-liuxiaozhou@bytedance.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Fri, 14 Dec 2018 17:06:33 +0100
Message-ID: <CANiq72ndmEBLm_0A6iKXta1rVhYgsaHBL6QE+UFa7xFt8xdzTA@mail.gmail.com>
Subject: Re: [PATCH v3] Compiler Attributes: don't pollute userspace with
 macro definitions
To:     liuxiaozhou@bytedance.com
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Paul Burton <paul.burton@mips.com>,
        Kees Cook <keescook@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 14, 2018 at 3:16 PM Xiaozhou Liu <liuxiaozhou@bytedance.com> wr=
ote:
>
> Macros 'inline' and '__gnu_inline' used to be defined in compiler-gcc.h,
> which was (and is) included entirely in (__KERNEL__ && !__ASSEMBLY__).
> Commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutual=
ly
> exclusive") had those macros exposed to userspace, unintentionally.
>
> Then commit a3f8a30f3f00 ("Compiler Attributes: use feature checks
> instead of version checks") moved '__gnu_inline' back into
> (__KERNEL__ && !__ASSEMBLY__) and 'inline' was left behind. Since 'inline=
'
> depends on '__gnu_inline', compiling error showing "unknown type name
> =E2=80=98__gnu_inline=E2=80=99" will pop up, if userspace somehow include=
s
> <linux/compiler.h>.
>
> Other macros like __must_check, notrace, etc. are in a similar situation.
> So just move all these macros back into (__KERNEL__ && !__ASSEMBLY__).
>
> Note:
>   1. This patch only affects what userspace sees.
>   2. __must_check (when !CONFIG_ENABLE_MUST_CHECK) and noinline_for_stack
>      were once defined in __KERNEL__ only, but we believe that they can
>      be put into !__ASSEMBLY__ too.
>
> Acked-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Xiaozhou Liu <liuxiaozhou@bytedance.com>

Thanks Xiaozhou, picked into compiler-attributes with a slightly
modified title (since it is not about compiler attributes this time),
and let's see if there is any problem with it in linux-next.

Nick: I kept your Ack, even if it is a different patch. Let me know if
you don't want to Ack this version.

Cheers,
Miguel