Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181130162015.83FE767357@newverein.lst.de> <CADGdYn46uQWfoDmRjk1OFj9fYXYbC669Ar=oVtnx141HcMFr8w@mail.gmail.com>
 <20181214094714.GA30043@lst.de>
In-Reply-To: <20181214094714.GA30043@lst.de>
From:   Amit Daniel Kachhap <amit.kachhap@arm.com>
Date:   Fri, 14 Dec 2018 21:45:03 +0530
Message-ID: <CADGdYn69reXed-DBMTCezNyNEgKn-h0NA-D6dnoRrJx2_bE71Q@mail.gmail.com>
Subject: Re: [PATCH v5] arm64: implement ftrace with regs
To:     duwe@lst.de
Cc:     Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        julien.thierry@arm.com, rostedt@goodmis.org, jpoimboe@redhat.com,
        mingo@redhat.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, takahiro.akashi@linaro.org,
        LAK <linux-arm-kernel@lists.infradead.org>,
        linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,
On Fri, Dec 14, 2018 at 3:18 PM Torsten Duwe <duwe@lst.de> wrote:
>
> On Thu, Dec 13, 2018 at 11:01:38PM +0530, Amit Daniel Kachhap wrote:
> > On Fri, Nov 30, 2018 at 9:53 PM Torsten Duwe <duwe@lst.de> wrote:
> >
> > Hi Torsten,
> >
> > I was testing your patch and it seems to work fine for function trace. However
> > function graph trace seems broken. Is it work in progress ? or I am
> > missing something.
>
> What did you base your tests on, you didn't specify?
> OTOH neither did I ;-) I precluded all addressees had the full picture.
>
> Precisely, I basically start with 4.19, but 4.20-rc shouldn't make a
> difference. BUT...
>
> > > [Changes from v4]
> > >
> > > * include Ard's feedback and pending changes:
> > >   - ADR/ADRP veneers
> > >   - ftrace_trampolines[2]
> > >   - add a .req for fp, just in case
> " [PATCH 1/2] arm64/insn: add support for emitting ADR/ADRP instructions "
> <20181122084646.3247-2-ard.biesheuvel@linaro.org> et.al, esp:
> Git-commit: bdb85cd1d20669dfae813555dddb745ad09323ba
>
> > >   - comment on the pt_regs.stackframe[2] mapping
> > > * include Mark's ftrace cleanup
> > >   - GLOBAL()
> > >   - prepare_ftrace_return(pc, &lr, fp)
> > >
> " [PATCH 1/6] linkage: add generic GLOBAL() macro "
> <20181115224203.24847-2-mark.rutland@arm.com> et.al., esp:
> Git-commit: 7dc48bf96aa0fc8aa5b38cc3e5c36ac03171e680
>
> change the API this patch set relies on. AFAIU they are on their way into
> mainline so I updated v5 accordingly. If you don't have these, just use v4;
> the other changes are only for compatibility and cosmetics.

Sorry I didn't mention my environment. I am using 4.20-rc3 and it has
all the above 8 extra patches
mentioned by you.
I read your change description in v3 patchset. You had mentioned there
that graph caller
is broken.

//Amit
>
> HTH,
>         Torsten
>