Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2293850imu; Fri, 14 Dec 2018 08:44:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/UlFnS/yPltIPLmErhd7kvwTrPduFLPgW2aIJmY+rbPvxx5SZjTh8/U/ldkB9+5AFQ9CZlB X-Received: by 2002:a65:6215:: with SMTP id d21mr3303478pgv.289.1544805842521; Fri, 14 Dec 2018 08:44:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544805842; cv=none; d=google.com; s=arc-20160816; b=dWzWnaVdGYFaKrMCyy6syZpE8dF+rtnve+O8vI/UCoNjcen1SwIYasi7lw+SnLuLH2 0fg07EqH+rFPYJ1+mGUn1i5hoK1QuLexam9Gcn5Ggfwcz957NvOhNzOA4aOnP8KZOq/s ewLWjTk9QD5AmOy8fAwyhGhXSji0+W+jpGHhK5WE2SWM/9h67p+HXN2BHje1uexx9Z3C hV/c50gK20+YOp8R7F9Vvec9+MuyHNQNKrLEjMrmzg2/+OBHiwoIIQze+yHkBZQmU7AT 6tOmBS2a70tJLxdqMqMes/gR3PFPrpYPireVUrQ1foNt6u0+w14/9kDS9E7kJ4QsL85U VuDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IXgpKRxjcDleHWDQbVIdOYUTSuwQqT/1MwGB3JMiMmE=; b=MX8GKRQBkxrT1F7dkpOr6mGdbU3E01GlgnPztkkep5gSX74MKEWeTNodNJrisgiLhl 0xkLv520ba5V9f5/1FD7FHnKwmahipHQLA2p8XrH5x+Svy9gN67jei6kjli6WC/DlshF 5lPRDFwnMLO15EkMwoGyNMLpwHfaxOOZAdj6XAbZA2dvU2v2ydQczjlDGCmCA0J9/fry x/D98l8P1j84RPrxowl24GlWVJqpfRbTUREn0WUheJa/5Ap1gDcmUptoIrQ3Ef8lHTcX cNmqjVbmTx037ZLWuzv3MjMSN0Mfj6ugEJY7g0xJM9jHfzf/DvihYoP605MsJ67rQT19 LNUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12si1031549pgh.368.2018.12.14.08.43.42; Fri, 14 Dec 2018 08:44:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729982AbeLNQmg (ORCPT + 99 others); Fri, 14 Dec 2018 11:42:36 -0500 Received: from verein.lst.de ([213.95.11.211]:48539 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729465AbeLNQmf (ORCPT ); Fri, 14 Dec 2018 11:42:35 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 15F1368DF5; Fri, 14 Dec 2018 17:42:34 +0100 (CET) Date: Fri, 14 Dec 2018 17:42:33 +0100 From: Christoph Hellwig To: Michael Ellerman Cc: Christoph Hellwig , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/34] powerpc/cell: move dma direct window setup out of dma_configure Message-ID: <20181214164233.GA27074@lst.de> References: <20181114082314.8965-1-hch@lst.de> <20181114082314.8965-13-hch@lst.de> <871s6r3sno.fsf@concordia.ellerman.id.au> <20181212143604.GA5137@lst.de> <87mup8uti0.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mup8uti0.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 15, 2018 at 12:29:11AM +1100, Michael Ellerman wrote: > I think the problem is that we don't want to set iommu_bypass_supported > unless cell_iommu_fixed_mapping_init() succeeds. > > Yep. This makes it work for me on cell on top of your v5. Thanks, this looks good. I've folded it with the slight change of moving the iommu_bypass_supported setup into cell_iommu_fixed_mapping_init.