Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] checkpatch: add Co-Developed-by to signature tags
To:     Greg KH <gregkh@linuxfoundation.org>, Joe Perches <joe@perches.com>
Cc:     apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, niklas.cassel@linaro.org
References: <1544792494-15485-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com>
 <20181214161344.GA10654@kroah.com>
From:   Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Message-ID: <911d67b4-2881-9895-487f-dac352fe8a36@linaro.org>
Date:   Fri, 14 Dec 2018 18:18:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181214161344.GA10654@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/14/18 17:13, Greg KH wrote:
> On Fri, Dec 14, 2018 at 07:52:15AM -0800, Joe Perches wrote:
>> On Fri, 2018-12-14 at 14:01 +0100, Jorge Ramirez-Ortiz wrote:
>>> As per Documentation/process/submitting-patches, Co-developed-by is a
>>> valid signature.
>>>
>>> This commit removes the warning.
>> Your commit message doesn't match your subject.
>>
>> A couple variants have been documented and only
>> one should actually be used.
>>
>> $ git grep -i co-developed-by Documentation/process/
>> Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
>> Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
>> Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer
>>
>> $ git log --grep="co-developed-by:" -i | \
>>    grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn
>>       80 Co-developed-by:
>>       40 Co-Developed-by:
>>
>> So which should it be?
> "Co-developed-by:" please.
>
> Yeah, I wrote the original one wrong here, sorry.
>
>> btw: I prefer neither as I think Signed-off-by: is sufficient.
> Nope, sorry, it is not, we need something like this which is why it was
> added.
>
> thanks,
>
> greg k-h
> .
>
I'll update both