Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp36712imu; Fri, 14 Dec 2018 13:58:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/UOZEVhks6yWwfAuKMutyyVT0hnHeu3jd3Ai/pmWOCKMEiOWru4gmOpjJonIQ90FS8vjg0A X-Received: by 2002:a62:2a4b:: with SMTP id q72mr4352394pfq.61.1544824734043; Fri, 14 Dec 2018 13:58:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544824734; cv=none; d=google.com; s=arc-20160816; b=ZLzJo2l5MyLj0pGO+8sPqaLqiPd7Wz0qQtpvINc7qePHzPUbMFY2b6s0cJmySjUn/Z j0hW6E/kBH7DBIfDrMoDeBddYn7ILRWrnzkVXm7YalUGygAatsMUc0804jQQsiTPWPWM J/H7zLG+PKOU/q7PztYeNNqz5iWIup0m8MTw6qzdnQBF8j6Trnus1D9ZVUEVkDrolw/c fV8i1uXSs9sKjTg0QCtYCxIOJ+aVF0a/9/+QHAJwpEjeRvNydOhMnPswVbNnZi2wcgn/ sfNBmGJbVMcWIVaOO6eNx1VVy6tx4EPyIxg7lB79BgGu7GMoFLNtfIbPjNcx03fWXnoB iT3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:user-agent:from:message-id :references:to:subject:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=nyH2qJmg0Khu8gqmBPMWJHpztywGLumowDszfV9I0lI=; b=rvD7EUTmpWd9wFeCcnAJBtbNRBbtORm+p8tpA7O+cKIQIBjPBEWWfIcKacqgIZaQC8 VvRZW8jAvUydxQMzRF3d5rYHDwQWg2t+4RI7MlFZ8s/5BVF+aQJ0/OuJ4pK57nJpfzSb PK03E+XEn0T6p6kHYhxCcyi5oduW79MuHa3Qq5wnUGMPIKRgtySBXRGhNVmT/wA9gjry nfGThQDWQY3ApwigIvPNJaOd2R8crhW/4iJPUJpeat+32SZHfHSQHWLlDRgkDmeJQvQ5 nVfctAxs6SlZgHYggljq+dl28oI8WAEGP1ffA8YRezSvSnx8qJFnT0aF0twmqhbecU8q AotQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dCUiBZXb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay7si4698088plb.410.2018.12.14.13.58.38; Fri, 14 Dec 2018 13:58:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dCUiBZXb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731304AbeLNV5l (ORCPT + 99 others); Fri, 14 Dec 2018 16:57:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:51776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731020AbeLNV5j (ORCPT ); Fri, 14 Dec 2018 16:57:39 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF6F32080F; Fri, 14 Dec 2018 21:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544824659; bh=nyH2qJmg0Khu8gqmBPMWJHpztywGLumowDszfV9I0lI=; h=In-Reply-To:Subject:To:References:From:Cc:Date:From; b=dCUiBZXbBLqIntfGQnqgIQLszmVe5L8JTXil0FfLrHqzGxJ0oUziocv/dWnME3sg8 QUJSNwhUUjNLh37lkb8NZCZNNIdOb9fNGGNbFsdfSWN1VOwYStFmdIZq3YYpuBiQww 2wCOFEpMwpXX6s97a/8viIGLE59LDh7Lzp9QSPwI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20181210073240.32278-3-weiyi.lu@mediatek.com> Subject: Re: [PATCH v3 01/12] clk: mediatek: fixup: Disable tuner_en before change PLL rate To: Matthias Brugger , Nicolas Boichat , Rob Herring , Stephen Boyd , Weiyi Lu References: <20181210073240.32278-1-weiyi.lu@mediatek.com> <20181210073240.32278-3-weiyi.lu@mediatek.com> Message-ID: <154482465853.19322.3763394015657394960@swboyd.mtv.corp.google.com> From: Stephen Boyd User-Agent: alot/0.8 Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Owen Chen Date: Fri, 14 Dec 2018 13:57:38 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Why is "fixup" in the subject of this patch? Quoting Weiyi Lu (2018-12-09 23:32:29) > From: Owen Chen >=20 > PLLs with tuner_en bit, such as APLL1, need to disable > tuner_en before apply new frequency settings, or the new frequency > settings (pcw) will not be applied. > The tuner_en bit will be disabled during changing PLL rate > and be restored after new settings applied. > Another minor change is to correct the macro name of pcw change bit > to CON1_PCW_CHG because PCW_CHG(BIT31) is on CON1. >=20 > Cc: > Signed-off-by: Owen Chen So there should be some Fixes: tag here too so we know what commit is being fixed?