Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 15 Dec 2018 11:27:51 -0800 (PST)
Message-Id: <20181215.112751.741520579999284155.davem@davemloft.net>
To:     eric.dumazet@gmail.com
Cc:     laoar.shao@gmail.com, edumazet@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: minor optimization for calculating
 packets_out in tcp connect
From:   David Miller <davem@davemloft.net>
In-Reply-To: <48971720-96e1-a48f-a1f5-3a96aa3fae7a@gmail.com>
References: <1544866389-11168-1-git-send-email-laoar.shao@gmail.com>
        <48971720-96e1-a48f-a1f5-3a96aa3fae7a@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 15 Dec 2018 04:59:00 -0800

> 
> 
> On 12/15/2018 01:33 AM, Yafang Shao wrote:
>> When we building a syn packet, the tcp_skb_pcount(skb) is always 1,
>> which is set in tcp_init_nondata_skb().
>> Regarding the syn_data, it is set through
>> memcpy(syn_data->cb, syn->cb, sizeof(syn->cb)),
>> which is always 1 as well.
>> 
>> So we don't need to use tcp_skb_pcount(skb), that could give us a
>> little improvement.
>>
> 
> I dunno, I find current code more self-documented.
> 
> This is not fast path, so I would suggest we keep it.

I agree, I won't be applying this.