Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 15 Dec 2018 23:28:59 -0800 (PST)
Message-Id: <20181215.232859.365899686560746192.davem@davemloft.net>
To:     semen.protsenko@linaro.org
Cc:     jchapman@katalix.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, g.nault@alphalink.fr
Subject: Re: [PATCH] l2tp: Add protocol field decompression
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181214175921.6859-1-semen.protsenko@linaro.org>
References: <20181214175921.6859-1-semen.protsenko@linaro.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Sam Protsenko <semen.protsenko@linaro.org>
Date: Fri, 14 Dec 2018 19:59:21 +0200

> When Protocol Field Compression (PFC) is enabled, the "Protocol" field
> in PPP packet will be received without leading 0x00. See section 6.5 in
> RFC 1661 for details. So let's decompress protocol field if needed, the
> same way it's done in drivers/net/ppp/pptp.c.
> 
> In case when "nopcomp" pppd option is not enabled, PFC (pcomp) can be
> negotiated during LCP handshake, and L2TP driver in kernel will receive
> PPP packets with compressed Protocol field, which in turn leads to next
> error:
> 
>     Protocol Rejected (unsupported protocol 0x2145)
> 
> because instead of Protocol=0x0021 in PPP packet there will be
> Protocol=0x21. This patch unwraps it back to 0x0021, which fixes the
> issue.
> 
> Sending the compressed Protocol field will be implemented in subsequent
> patch, this one is self-sufficient.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Applied, thanks.