Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 16 Dec 2018 11:56:34 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jeremy Fertic <jeremyfertic@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] staging: iio: adt7316: remove dac vref buffer
 bypass from adt751x
Message-ID: <20181216115634.2e75aa75@archlinux>
In-Reply-To: <20181212005503.28054-10-jeremyfertic@gmail.com>
References: <20181212005503.28054-1-jeremyfertic@gmail.com>
        <20181212005503.28054-10-jeremyfertic@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 11 Dec 2018 17:55:01 -0700
Jeremy Fertic <jeremyfertic@gmail.com> wrote:

> The option to allow the external vref to bypass the reference buffer is
> only available for adt7316/7/8. Remove the attributes for adt751x as
> well as the chip->id checks from the show and store functions.
> 
> Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
Another good little cleanup, well separated from the other bits so
applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.,

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 3348fdf08f2e..bca599d8c51c 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -964,9 +964,6 @@ static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
>  	struct iio_dev *dev_info = dev_to_iio_dev(dev);
>  	struct adt7316_chip_info *chip = iio_priv(dev_info);
>  
> -	if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
> -		return -EPERM;
> -
>  	return sprintf(buf, "%d\n",
>  		!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_AB));
>  }
> @@ -981,9 +978,6 @@ static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
>  	u8 dac_config;
>  	int ret;
>  
> -	if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
> -		return -EPERM;
> -
>  	dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_AB);
>  	if (buf[0] == '1')
>  		dac_config |= ADT7316_VREF_BYPASS_DAC_AB;
> @@ -1009,9 +1003,6 @@ static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
>  	struct iio_dev *dev_info = dev_to_iio_dev(dev);
>  	struct adt7316_chip_info *chip = iio_priv(dev_info);
>  
> -	if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
> -		return -EPERM;
> -
>  	return sprintf(buf, "%d\n",
>  		!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_CD));
>  }
> @@ -1026,9 +1017,6 @@ static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
>  	u8 dac_config;
>  	int ret;
>  
> -	if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
> -		return -EPERM;
> -
>  	dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_CD);
>  	if (buf[0] == '1')
>  		dac_config |= ADT7316_VREF_BYPASS_DAC_CD;
> @@ -1713,8 +1701,6 @@ static struct attribute *adt7516_attributes[] = {
>  	&iio_dev_attr_DAC_update_mode.dev_attr.attr,
>  	&iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
>  	&iio_dev_attr_update_DAC.dev_attr.attr,
> -	&iio_dev_attr_DA_AB_Vref_bypass.dev_attr.attr,
> -	&iio_dev_attr_DA_CD_Vref_bypass.dev_attr.attr,
>  	&iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
>  	&iio_dev_attr_VDD.dev_attr.attr,
>  	&iio_dev_attr_in_temp.dev_attr.attr,