Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1569879imu; Sun, 16 Dec 2018 04:02:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/VF7vnHLn6cbmgFBOXMtBjWDHMVeEbNwegWxRjjNb0KX4aPbHfyvdhZY7xhM56XJW8lww4d X-Received: by 2002:a63:b649:: with SMTP id v9mr8866709pgt.436.1544961730324; Sun, 16 Dec 2018 04:02:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544961730; cv=none; d=google.com; s=arc-20160816; b=ntWyUb8gJ44TRDxUTW8BzQj6VI5Fj2uEmN4nLD+GRFIjDwPE9i3ZZYLY5uPkpio1vf q50PTUTQL7NfpHLdw12imnSxaVvGNMKNkD/a7I2p9pul61McHb1VSUnsu6sgi98YRWC2 96XqerovWB/SeSpM9+zznOtmKpbJsqCu88l4SsM2tOOflMOok8c2swGMfu27zpKarTqi xakhjn35ZfIgTFrF7RYlAFhgUPwtDtWGzW/WfXsp0hCauQjtKmERmMNf0PWRcldN4Lfm IGbTXZgUH2Brgm86V6MRI5GqEja5KC32nzNZOrPFzs1mRanROdZLrfuqhsm06V+B6tEA jN0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fUEiKiYWPLE7AaIabIkyWfuRBcfyTpoosNMafAq+z7A=; b=v4635k9Z0SxbRlB4O7R/MrUXIjH6gbRoej8qjmlUDyQAbZNSuf3LZaGwUA7eTfIBhq THRQW4H5haBc1XnrMZpyZWyqvQOMA7Ab2efGcYAj60GQXRo4SwgiHfz3YoxWGXf5+l38 YAiEUcPBNfYjzdXMEAELfgh4xaYWEuqFeWtS1Mo9801AyVDzioR+O6yRCmLJpCYq4ajN Bo6/84/PZt8JptBsVk8MH0APY4PYwy5ylDCwFgOS3o1PJ88RkcOJGsz8rpwJTTG3VHq4 Aa/KE18U/Q2Lh8rriS8SRPb9LJG/EbA4B1fWUeB/BQErWAQVkJD7kR1qeA849n4f7V4f x0WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWJnnyLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si8098750plt.213.2018.12.16.04.01.54; Sun, 16 Dec 2018 04:02:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWJnnyLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730413AbeLPMAb (ORCPT + 99 others); Sun, 16 Dec 2018 07:00:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:38020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730021AbeLPMAb (ORCPT ); Sun, 16 Dec 2018 07:00:31 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A618217FA; Sun, 16 Dec 2018 12:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544961630; bh=SWAbNpwmPxtSQZoG2LwOP88PTvgzJv0TFx7ot4Opzqw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jWJnnyLFXFk++kKfI5rg1Uf5CC4yGx868DLYth3aVBsiJcU5ftTKtrNQun8KlKfI/ W1EX/EGsj9sOPYFhfSjEHFma9Lxw+eBxDGTOmtQweQaePkzCtUhnQT7bwdpIgTKxBE Zl7X+8OwIqOMH2ZpY2bNzCxzN1h+/XIQRCBxKIfg= Date: Sun, 16 Dec 2018 12:00:25 +0000 From: Jonathan Cameron To: Jeremy Fertic Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] staging: iio: adt7316: correct spelling of ADT7316_DA_EN_VIA_DAC_LDCA Message-ID: <20181216120025.3dffee80@archlinux> In-Reply-To: <20181212005503.28054-12-jeremyfertic@gmail.com> References: <20181212005503.28054-1-jeremyfertic@gmail.com> <20181212005503.28054-12-jeremyfertic@gmail.com> X-Mailer: Claws Mail 3.17.2 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Dec 2018 17:55:03 -0700 Jeremy Fertic wrote: > Change LDCA to LDAC. > > Signed-off-by: Jeremy Fertic Ah. Here it is ;) As commented on earlier. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/addac/adt7316.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index 58b462ad0c83..020d695ded97 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -119,7 +119,7 @@ > */ > #define ADT7316_ADCLK_22_5 0x1 > #define ADT7316_DA_HIGH_RESOLUTION 0x2 > -#define ADT7316_DA_EN_VIA_DAC_LDCA 0x8 > +#define ADT7316_DA_EN_VIA_DAC_LDAC 0x8 > #define ADT7516_AIN_IN_VREF 0x10 > #define ADT7316_EN_IN_TEMP_PROP_DACA 0x20 > #define ADT7316_EN_EX_TEMP_PROP_DACB 0x40 > @@ -847,7 +847,7 @@ static ssize_t adt7316_show_DAC_update_mode(struct device *dev, > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > > - if (!(chip->config3 & ADT7316_DA_EN_VIA_DAC_LDCA)) > + if (!(chip->config3 & ADT7316_DA_EN_VIA_DAC_LDAC)) > return sprintf(buf, "manual\n"); > > switch (chip->dac_config & ADT7316_DA_EN_MODE_MASK) { > @@ -876,7 +876,7 @@ static ssize_t adt7316_store_DAC_update_mode(struct device *dev, > u8 data; > int ret; > > - if (!(chip->config3 & ADT7316_DA_EN_VIA_DAC_LDCA)) > + if (!(chip->config3 & ADT7316_DA_EN_VIA_DAC_LDAC)) > return -EPERM; > > ret = kstrtou8(buf, 10, &data); > @@ -907,7 +907,7 @@ static ssize_t adt7316_show_all_DAC_update_modes(struct device *dev, > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > > - if (chip->config3 & ADT7316_DA_EN_VIA_DAC_LDCA) > + if (chip->config3 & ADT7316_DA_EN_VIA_DAC_LDAC) > return sprintf(buf, "0 - auto at any MSB DAC writing\n" > "1 - auto at MSB DAC AB and CD writing\n" > "2 - auto at MSB DAC ABCD writing\n" > @@ -929,7 +929,7 @@ static ssize_t adt7316_store_update_DAC(struct device *dev, > u8 data; > int ret; > > - if (chip->config3 & ADT7316_DA_EN_VIA_DAC_LDCA) { > + if (chip->config3 & ADT7316_DA_EN_VIA_DAC_LDAC) { > if ((chip->dac_config & ADT7316_DA_EN_MODE_MASK) != > ADT7316_DA_EN_MODE_LDAC) > return -EPERM; > @@ -2128,7 +2128,7 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus, > } > > if (!chip->ldac_pin) { > - chip->config3 |= ADT7316_DA_EN_VIA_DAC_LDCA; > + chip->config3 |= ADT7316_DA_EN_VIA_DAC_LDAC; > if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX) > chip->config1 |= ADT7516_SEL_AIN3; > }