Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1652417imu; Sun, 16 Dec 2018 05:56:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/UtMObajlmDIbFZBOk82YSuBg9tkTlcar8ag5Wclokh8WNHcamkMLuOW9AuNnEr58T7fg8b X-Received: by 2002:a62:5fc4:: with SMTP id t187mr9671431pfb.66.1544968561096; Sun, 16 Dec 2018 05:56:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544968561; cv=none; d=google.com; s=arc-20160816; b=jacwyJAZ3U4jqA78Uf1/Y6c5OGjzoFRCmHPtgoBsSARBHrzjaX9+/kCbGhlsWAltmY P3/ak/zhm1dybiBBrnchGL+X2E9lQ0BqSAsfFxTLVgM6IwhKFEVp1ApHTrAEW1iMu2w4 8YvN/UCzqBCYd60sANl2lOEFMDboDmVSeKSpJ9xN3Z2ExXcEhApXnfwEr5oAihGc3WM3 Sk51Qo3PJvPAzEHw6rKSxFqDfz7xmrKmVKvj0ycIyDsrWv8X2X5vSemfyv4wCHqAyfO8 V4VpA9vF50a521rHLncRThiVl4arjaoFthzGw35VpN+63ko7G7m3JCd4SEQNqGdoYnAg ycKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=eqtmmc25RGkLIj89dbCWlapEpwK+tWYObnEA5yUq+s8=; b=IxEZRjiauhKLuFjyL3nvpxrUuWMRUtWUnFzpdZ3BudQww+gL9Wpo/RpMgBThNQ/f/A GnsSmiMn4UplFmGr+9VmBBcpeE3NPCgnTdA59BXybn2XvroSCOAfIkIrgbLVWx35YDcW SnpO0rphSIXH36a7nJcwSh2S3EGoo5Qz8FQ+TRANIhL7hve9qBN1n85OQdAEta56yqQ6 PLQZ7Hs4corO0DT3VXmybBjbp/LtcQEGYqDZffbIkraw7+n1HEET5d5SRGTqdse8e1ey X92itGW8+idH2Er9vkfbwuWzRAdF4IDuILJo1VIcRtSvexVLOjqrwcZGd13Gg2/bb4Ws zCgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QIxOvGjj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si8268902pgb.219.2018.12.16.05.55.45; Sun, 16 Dec 2018 05:56:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QIxOvGjj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730640AbeLPNyU (ORCPT + 99 others); Sun, 16 Dec 2018 08:54:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:33212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729859AbeLPNyU (ORCPT ); Sun, 16 Dec 2018 08:54:20 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63E162086C; Sun, 16 Dec 2018 13:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544968459; bh=1jo1r9c4MFEHJEYkcKZKKVVsTdA6D7xWI05n9rB+cvg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QIxOvGjj4Uow2Wo85CclAyYl2uw+hCg5aDPjROomTX7gC6ZBfqh2Dd+S8jAtj0snJ 9hmWOE29pCrVYdnUcVukf1Ab/kv9FfwRG4F5i5Cgr9yrKtiSqER8aWXLjVjVD6Clfi aqy0Co5Sd1ONHMeE87oNhU07rJtFLAV296vVfDV4= Date: Sun, 16 Dec 2018 13:54:14 +0000 From: Jonathan Cameron To: Stefan Popa Cc: , , , , , , , , , , Subject: Re: [PATCH 08/11] staging: iio: adc: ad7606: Add OF device ID table Message-ID: <20181216135414.66e4aceb@archlinux> In-Reply-To: <1544705183-13288-9-git-send-email-stefan.popa@analog.com> References: <1544705183-13288-1-git-send-email-stefan.popa@analog.com> <1544705183-13288-9-git-send-email-stefan.popa@analog.com> X-Mailer: Claws Mail 3.17.2 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Dec 2018 14:46:20 +0200 Stefan Popa wrote: > The driver does not have a struct of_device_id table, but supported > devices are registered via Device Trees. This patch adds and OF device > ID table. > > Signed-off-by: Stefan Popa Applied. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7606_par.c | 10 ++++++++++ > drivers/staging/iio/adc/ad7606_spi.c | 10 ++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c > index 6269ee7..ac0c7b0 100644 > --- a/drivers/staging/iio/adc/ad7606_par.c > +++ b/drivers/staging/iio/adc/ad7606_par.c > @@ -90,12 +90,22 @@ static const struct platform_device_id ad7606_driver_ids[] = { > > MODULE_DEVICE_TABLE(platform, ad7606_driver_ids); > > +static const struct of_device_id ad7606_of_match[] = { > + { .compatible = "adi,ad7605-4" }, > + { .compatible = "adi,ad7606-4" }, > + { .compatible = "adi,ad7606-6" }, > + { .compatible = "adi,ad7606-8" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, ad7606_of_match); > + > static struct platform_driver ad7606_driver = { > .probe = ad7606_par_probe, > .id_table = ad7606_driver_ids, > .driver = { > .name = "ad7606", > .pm = AD7606_PM_OPS, > + .of_match_table = ad7606_of_match, > }, > }; > > diff --git a/drivers/staging/iio/adc/ad7606_spi.c b/drivers/staging/iio/adc/ad7606_spi.c > index 9291598..2608d34 100644 > --- a/drivers/staging/iio/adc/ad7606_spi.c > +++ b/drivers/staging/iio/adc/ad7606_spi.c > @@ -57,9 +57,19 @@ static const struct spi_device_id ad7606_id[] = { > }; > MODULE_DEVICE_TABLE(spi, ad7606_id); > > +static const struct of_device_id ad7606_of_match[] = { > + { .compatible = "adi,ad7605-4" }, > + { .compatible = "adi,ad7606-4" }, > + { .compatible = "adi,ad7606-6" }, > + { .compatible = "adi,ad7606-8" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, ad7606_of_match); > + > static struct spi_driver ad7606_driver = { > .driver = { > .name = "ad7606", > + .of_match_table = ad7606_of_match, > .pm = AD7606_PM_OPS, > }, > .probe = ad7606_spi_probe,