Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1780891imu;
        Sun, 16 Dec 2018 08:38:32 -0800 (PST)
X-Google-Smtp-Source: AFSGD/UEOt/CTz7OgVJKGsm56xJzUfu7gZEcBMrzMwmRmPBIuK1iBdAdLHxM1c4Qr9pkjghJzOW2
X-Received: by 2002:a17:902:12f:: with SMTP id 44mr9956848plb.74.1544978312012;
        Sun, 16 Dec 2018 08:38:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1544978311; cv=none;
        d=google.com; s=arc-20160816;
        b=aE/5psxK5csYZJMiwGnsXllhNJYdlnWGkE3lGwgWhCnb8xvWJTL2aAi8gqPrJo0uw0
         T8SmptoOyOoyguMObsIJFFd/2Mbu5JTV/G/5auYWWEJNPrDQ94LGyJqUWESwsX5tboz1
         z3boqqyCZ0Q8mVeJNNtRuFCS1x1dcLLvO109cvkj/DZaeEXQewqZ1oIu2jk6Co8yCmXS
         9zb5Cn6ntrjuxlS5dFUHiv2NDKMChVAG1dXVIXBXziyPz4wVbmWtodnaNPwPOeCyxsRD
         0rpxLyzeNy5rugNN1N/wF5xYHdNtnIh4lVLev/choRa1kPAJMVSr4T82LM+qLs74uPki
         L3pw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=SUS8RZ7cnCNXhlW76wdrqKXtYu+jDOCv6pGs5R4R2BU=;
        b=EfWucmjgGTGvCPQBoWvQccMoo1dcbCTPFOc+E8Ay55vx7F5gCWYJjw75eYD4ieyawu
         1tMqX5A+y4ytDfycEf79O2SBoR3wNqpllDmWp6ZH2hUasipiBTms/8g7PAaFpJoFBQ+S
         O4+zS09g0kEtPtKFx5O4RP4Y+KH9gc/RtexETvYnIGULJYXje7nefcRJ8xxRvWDxSFLu
         hEdCl7Ji4Jciw8BZNnPSXcNMxGXb/W5ezsufZYK08xJwQlsURKzcMqtUlTfrEBB7rwSi
         YmZJgVNKJUHvFhakLd1F3fsnFtPb0BTOUzVWTFuYL038B2P2nUPpMx43kWoSlw06imF6
         S7Wg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id b61si8972003plb.70.2018.12.16.08.38.13;
        Sun, 16 Dec 2018 08:38:31 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730690AbeLPQ0j (ORCPT <rfc822;arandomawesomegeek@gmail.com>
        + 99 others); Sun, 16 Dec 2018 11:26:39 -0500
Received: from verein.lst.de ([213.95.11.211]:57847 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729822AbeLPQ0j (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 16 Dec 2018 11:26:39 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 3E6B468DD3; Sun, 16 Dec 2018 17:26:38 +0100 (CET)
Date:   Sun, 16 Dec 2018 17:26:38 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Colin King <colin.king@canonical.com>
Cc:     Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, chaitanya.kulkarni@wdc.com
Subject: Re: [PATCH][next] nvmet: fix comparison of a u16 with -1
Message-ID: <20181216162638.GB12651@lst.de>
References: <20181214183121.17445-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181214183121.17445-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks, applied.

Maybe it might be worth adding a NVME_NO_ERR_LOC defintion to clean
this up a bit more.  Chaitanya, can you look into that?