Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     "Dmitry V. Levin" <ldv@altlinux.org>, Jens Axboe <axboe@kernel.dk>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uapi: linux/blkzoned.h: fix BLKGETZONESZ and
 BLKGETNRZONES definitions
Thread-Topic: [PATCH] uapi: linux/blkzoned.h: fix BLKGETZONESZ and
 BLKGETNRZONES definitions
Thread-Index: AQHUlOGnwpt3q7yotU+90ZUB+2A3JQ==
Date:   Sun, 16 Dec 2018 23:50:50 +0000
Message-ID: <BYAPR04MB5816E9F89EAF570A21C5D5A8E7A30@BYAPR04MB5816.namprd04.prod.outlook.com>
References: <20181216014951.GA14229@altlinux.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f43daae8-dcaa-47d7-4e5c-08d663b14f21
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2018 23:50:50.5586
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5286
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2018/12/16 10:50, Dmitry V. Levin wrote:=0A=
> According to the documentation in include/uapi/asm-generic/ioctl.h,=0A=
> _IOW means userspace is writing and kernel is reading, and=0A=
> _IOR means userspace is reading and kernel is writing.=0A=
> =0A=
> In case of these two ioctls, kernel is writing and userspace is reading,=
=0A=
> so they have to be _IOR instead of _IOW.=0A=
> =0A=
> Fixes: 72cd87576d1d8 ("block: Introduce BLKGETZONESZ ioctl")=0A=
> Fixes: 65e4e3eee83d7 ("block: Introduce BLKGETNRZONES ioctl")=0A=
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>=0A=
> ---=0A=
> =0A=
> Since both ioctls were introduced after 4.19,=0A=
> please make sure they are fixed in 4.20.=0A=
> Thanks.=0A=
> =0A=
>  include/uapi/linux/blkzoned.h | 4 ++--=0A=
>  1 file changed, 2 insertions(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzoned.=
h=0A=
> index 8f08ff9bdea0..6fa38d001d84 100644=0A=
> --- a/include/uapi/linux/blkzoned.h=0A=
> +++ b/include/uapi/linux/blkzoned.h=0A=
> @@ -141,7 +141,7 @@ struct blk_zone_range {=0A=
>   */=0A=
>  #define BLKREPORTZONE	_IOWR(0x12, 130, struct blk_zone_report)=0A=
>  #define BLKRESETZONE	_IOW(0x12, 131, struct blk_zone_range)=0A=
> -#define BLKGETZONESZ	_IOW(0x12, 132, __u32)=0A=
> -#define BLKGETNRZONES	_IOW(0x12, 133, __u32)=0A=
> +#define BLKGETZONESZ	_IOR(0x12, 132, __u32)=0A=
> +#define BLKGETNRZONES	_IOR(0x12, 133, __u32)=0A=
>  =0A=
>  #endif /* _UAPI_BLKZONED_H */=0A=
> =0A=
=0A=
Indeed, my bad.=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=