Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2372790imu; Mon, 17 Dec 2018 00:21:46 -0800 (PST) X-Google-Smtp-Source: AFSGD/X/DA6HpPaEJVXjtV3+NhkaIUQqeDg5MF7J1tsUQTDt6RljvR0bGgbV8VSDlGzQ/chnv/qj X-Received: by 2002:a63:bc02:: with SMTP id q2mr8172466pge.116.1545034906533; Mon, 17 Dec 2018 00:21:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545034906; cv=none; d=google.com; s=arc-20160816; b=aiOJ+Gfy1YIPe+PwnFqHtGxSU4xlhTGkYj6akfbpkdeq251r+QAdeP+qLc4cC/70P5 UA04sxRuDaXBYbgfryLQ1PZ4cNzrpERpC9rrht+IZuK1vnrC82pSsJub0QHj7gZkQ0fV gPDOclF1vy4skxITyZW3ZBNwF3FauhvS78WummtGEVAJUBCJZdUNYzHJ3PlizgehdMIn q/il+l0qs4oYNBpGyrGtcY+b2YEKh+Q6E/dNZDT+28bU9EzHkuO4nNmEliPbj0jdCd7s JUPTchZPIg7ossD7zDQypztc4EeDshRqTyKHmJStxplJS5hSveDKoWzMNeMrn+oREIO9 7ZdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eEn10tDHPRCTPqxtaTbqhwcamge2X278wDz5PkOYG/E=; b=npPdNRxMND0Sehqrt677bn9kBgY4M6YC+qrXgIi2Is0vRRtJd7Q0YxwnkYdA+7UeLI h1SOPGuU4dCCj82vIdoSKIAJ2BDKF/nAFThs5A5Pi1Fv0pUuznWptCXpafEHnxaxW6GQ LZN3bjsy8w2AvFXuYT0P2U6vrnos2nDr4giDtiWbEidTHwxRp93Jk/Ckvdpd8ub2NAEU 78lGXODxWJGUv2D0Gm7FkIrX7aGz1Yw/z/6ziaJNrjpLAIv+dAQ5lolVJ41c1pDeg9TQ cg6JdCTgsl8Od0p4TX2IYmnOk45pZ8fb2n9ADhoxucujiZplmVEPj8nWqNg0BHKgeQjv +acQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2e8oEfH1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si11243886pfd.281.2018.12.17.00.21.31; Mon, 17 Dec 2018 00:21:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2e8oEfH1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731429AbeLQIQr (ORCPT + 99 others); Mon, 17 Dec 2018 03:16:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:51880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbeLQIQq (ORCPT ); Mon, 17 Dec 2018 03:16:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0E3020672; Mon, 17 Dec 2018 08:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545034606; bh=kP+CYDAAQ6LBKSCAHh7s4Yx+Ha9G0XnsqeKef2V+U0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2e8oEfH1VGvJgJgJhhnJR0utg1/I+2s/iLsbNSqldenW4KvuAM/4pb/XcGGCfkux8 q1wHXsPby5PKt8Zm0XG3Fp3/L+MqQGnNBmBRd3qs2fQBiJdUWlqbHtx5dmMtQxJ4Tz 5y983TRnRcE7mQutrtAfF87PO/OESbZnZMLmWCe8= Date: Mon, 17 Dec 2018 09:16:40 +0100 From: Greg KH To: Amir Mahdi Ghorbanian Cc: marvin24@gmx.de, devel@driverdev.osuosl.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, ac100@lists.launchpad.net Subject: Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues Message-ID: <20181217081640.GA16368@kroah.com> References: <1544979463-10126-1-git-send-email-indigoomega021@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544979463-10126-1-git-send-email-indigoomega021@gmail.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote: > @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > break; > case 2: /* first byte after command */ > if (status == (I2C_SL_IRQ | RNW | RCVD)) { > - udelay(33); > + usleep_range(0, 33); Why is this a valid range to sleep for for this device? Have you been able to verify/test this? thanks, greg k-h