Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2501475imu; Mon, 17 Dec 2018 03:07:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/W0YUf40uvcY0D5J4PrwlMcniPpklENt7PUJrL7HQPnNDd0DYTR2U9zPRFIaPYXToO++wtR X-Received: by 2002:a63:e711:: with SMTP id b17mr11472464pgi.363.1545044825111; Mon, 17 Dec 2018 03:07:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545044825; cv=none; d=google.com; s=arc-20160816; b=Zp/zToOmEBqdTx02gAiOs3T7GZsoJjR9phPiW9j5D4/zfNfEeF0q1Og9IwShjyzDiB l3zGa3Jnzw14Y6ar01InAeXEKAQcAh8Yg6Ghvq6mRPZa7XFhFehXWv3Rs94O6UniD5N9 y2r83Z3bOfrplfi8vyRc+UvNs7D2EM36wmGFrLDnTD8uPr8IvcGEWcOMU+YBgV6cptzA bbOmaI9cNYnPfdI9GBADe2894qwych4GuzwYIXHqbPFznCsSHiXpy4JmlFNa7eaWj1n0 V+Aunc2gkeLCExhE3tMVsq9yYcC6PuSv0EMu4yH+sIRxVRDfnnVkmYukfKK0XdB7mNAJ 0fUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=iHILWyjBiWoh/Mp/1Wn6Eaw5BqGzdGN0bJ5Mpb6gKr4=; b=ITMRf5+tBRJc+9BoCtnGdWtVM9ABwx4CKOsflSCyxekghoRbgzm5YQLO1igraSwCVj QtEPkt4sfrcLxcqgHl9/mjHpfdCxGiOk9LreDF1+XNhCFk7GcXesthMJO0clRelTdYLR TZQcifscWYPGULCXZMqcRVuvYd/hTTzaNvvHHAODHdm70NZaHuntQfxkxE3+9wLtnrmF xMAvx5P9MhNqRfWqG6OqHDqvJYSiiXLVNFE1neeD3iyi/HuQggJLyxfbO6FxG8Ce+g5F h1sEEl+wlAa/oITQwaNv0pEh8Oq7cNP0xlAQ5T76sh1o8x5H3KeozOmzcN785dodIRwl oPwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34si10572484pgb.43.2018.12.17.03.06.49; Mon, 17 Dec 2018 03:07:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731849AbeLQLBr (ORCPT + 99 others); Mon, 17 Dec 2018 06:01:47 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53180 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbeLQLBq (ORCPT ); Mon, 17 Dec 2018 06:01:46 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F77DEBD; Mon, 17 Dec 2018 03:01:46 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3AC3E3F6A8; Mon, 17 Dec 2018 03:01:44 -0800 (PST) Date: Mon, 17 Dec 2018 11:00:28 +0000 From: Lorenzo Pieralisi To: Andrey Smirnov Cc: Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/3] Fixes for "PCIE support for i.MX8MQ" Message-ID: <20181217110028.GA14261@e107981-ln.cambridge.arm.com> References: <20181216230916.22982-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181216230916.22982-1-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 16, 2018 at 03:09:13PM -0800, Andrey Smirnov wrote: > Lorenzo: > > These are patches fixing things pointed out by Bjorn in [1] and [2] as > well as something I noticed while giving pci/next branch a try (#endif > placement). Hopefully this is at least somewhat helpful. > > Thanks, > Andrey Smirnov > > [1] lkml.kernel.org/r/20181214203828.GD20725@google.com > [2] lkml.kernel.org/r/20181214203042.GC20725@google.com > > Andrey Smirnov (3): > PCI: imx6: Fixup Kconfig and #endif placement > PCI: imx6: Invert checks in imx6_pcie_reset_phy() and > imx6_setup_phy_mpll() > PCI: imx6: Make fallthrough comments more consistent > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > drivers/pci/controller/dwc/pci-imx6.c | 29 ++++++++++++++++++--------- > 2 files changed, 21 insertions(+), 12 deletions(-) Andrey, please follow-up Lucas' remarks and submit a self-consistent patchset that I can apply on top of my pci/dwc branch (where I removed your previously queued patches). Thanks, Lorenzo