Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2505490imu; Mon, 17 Dec 2018 03:11:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/WSLfVrZvHx9FD1xtixeI7Bi6amgBzSHQDLo3vXacM+LPvapWhC4DkXYIkBGnfnWVw6kJAT X-Received: by 2002:a63:2d82:: with SMTP id t124mr11762445pgt.260.1545045065346; Mon, 17 Dec 2018 03:11:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545045065; cv=none; d=google.com; s=arc-20160816; b=CXFn2PwUMWFz2dZfkWGXzzu9es19X0JTwNgukZ+08jyJD4/oAC2vWmrnGy0BJ1UGFj 5F3lIJluP6vq9GYiBuZbUQkcpbGe5x9gwlFV704g6dRk/N8NQjriN8Gzu40lVPW5q8v1 SzXrDzNxBt+dz8CsuZSrSas4//80gTwgIG/4qNtYvVdjDBiga8RewW4YqYthcXyrjRIh ++xm8AL3h8YVm9yGd/LMgHbuXL5MpkqDJ7RmyC74qWzRuwpqfe3vYuH2QN7jAfEK9bqg pbeIy7V+rgBWO9Dh8SvGQJwlBOkpNM/BHjXWIlKGfpCixCSUOgtTEKp7PbK22Oh+UeVC dqvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=Mx0epix2ykSXpdmEA4G6kTUEjWztA/IB68BiC8uK8aQ=; b=x4AYNl49Oy7428U+kEFSHYJeXGgxu3LOjRTuyllX7sojeo9rdvHRqi4gVHj2FEEXKp +LtnaJKLPGjTvvJDiHecTNJEyEr5zV29zVQ36vDWhBSdsSfohQ4p04HbR3cFd6I79BU3 PVWb09KWwzPwg5e7V5wkYes9bq8t8GsoEZ5huF0nsV8F9hDJ8BbUgV41ysYqjKhh8tWw 7YRIvkwct+ZuHKjG4n9lGJQIS0187whE6zMD4Gyoug3DXHR10uqgzAu0O1dFiFjEYaG6 fO9aGjXfByP2ygWRfoXrwxq652lPGbICIhVx2c8KhxYD0s/wTcILv2gLoFHkt/SHczsb u2IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4si10659285pla.299.2018.12.17.03.10.50; Mon, 17 Dec 2018 03:11:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727225AbeLQLJk (ORCPT + 99 others); Mon, 17 Dec 2018 06:09:40 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:8933 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726692AbeLQLJj (ORCPT ); Mon, 17 Dec 2018 06:09:39 -0500 X-UUID: 54ce35dccf384a0bb4b92223aaa3e8c5-20181217 X-UUID: 54ce35dccf384a0bb4b92223aaa3e8c5-20181217 Received: from mtkcas34.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 990765218; Mon, 17 Dec 2018 19:09:31 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Dec 2018 19:09:30 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 17 Dec 2018 19:09:29 +0800 Message-ID: <1545044969.15380.1.camel@mhfsdcap03> Subject: Re: [PATCH] eint: add gpio vritual number select From: Chuanjia Liu To: Sean Wang CC: Linus Walleij , Matthias Brugger , , , , , , , , Date: Mon, 17 Dec 2018 19:09:29 +0800 In-Reply-To: References: <1544693783-25079-1-git-send-email-chuanjia.liu@mediatek.com> <1545016504.29293.10.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-12-16 at 23:59 -0800, Sean Wang wrote: > On Sun, Dec 16, 2018 at 7:15 PM Chuanjia Liu wrote: > > > > On Thu, 2018-12-13 at 11:33 -0800, Sean Wang wrote: > > > On Thu, Dec 13, 2018 at 1:36 AM wrote: > > > > > > > > From: Chuanjia Liu > > > > > > > > This patch add gpio vritual number select,avoid virtual gpio set SMT. > > > > > > s/gpio/GPIO/ > > > s/vritual/virtual/ > > > > > > Virtual GPIOs you said here that means these pins only used inside SoC > > > and not being exported to outside SoC, right? It seems this kind of > > > pins doesn't need SMT. > > > > > Yes,virtual gpio only used inside SOC and these pins doesn't need set > > SMT > > > > > > > > Signed-off-by: Chuanjia Liu > > > > --- > > > > drivers/pinctrl/mediatek/mtk-eint.h | 1 + > > > > drivers/pinctrl/mediatek/pinctrl-mt8183.c | 1 + > > > > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 9 ++++++--- > > > > 3 files changed, 8 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/pinctrl/mediatek/mtk-eint.h b/drivers/pinctrl/mediatek/mtk-eint.h > > > > index 48468d0..c16beaf 100644 > > > > --- a/drivers/pinctrl/mediatek/mtk-eint.h > > > > +++ b/drivers/pinctrl/mediatek/mtk-eint.h > > > > @@ -37,6 +37,7 @@ struct mtk_eint_hw { > > > > u8 ports; > > > > unsigned int ap_num; > > > > unsigned int db_cnt; > > > > + unsigned int vir_start; > > > > }; > > > > > > > > struct mtk_eint; > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8183.c b/drivers/pinctrl/mediatek/pinctrl-mt8183.c > > > > index 6262fd3..bbeafd3 100644 > > > > --- a/drivers/pinctrl/mediatek/pinctrl-mt8183.c > > > > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8183.c > > > > @@ -497,6 +497,7 @@ > > > > .ports = 6, > > > > .ap_num = 212, > > > > .db_cnt = 13, > > > > + .vir_start = 180, > > > > }; > > > > > > > > static const struct mtk_pin_soc mt8183_data = { > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > > > > index 4a9e0d4..ca3bae1 100644 > > > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > > > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > > > > @@ -289,9 +289,12 @@ static int mtk_xt_set_gpio_as_eint(void *data, unsigned long eint_n) > > > > if (err) > > > > return err; > > > > > > > > - err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, MTK_ENABLE); > > > > - if (err) > > > > - return err; > > > > + if (gpio_n < hw->eint->hw->vir_start) { > > > > + err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, > > > > + MTK_ENABLE); > > > > + if (err) > > > > + return err; > > > > + } > > > > > > The changes will break these SoCs without a properly configured vir_start. > > > > > > If SMT seems unnecessary for these kinds of virtual GPIOs pin in the > > > path, we can do it as > > > > > > err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, > > > MTK_ENABLE); > > > /* please add comments for the exclusion condition */ > > > if (err && err != -ENOTSUPP) > > > return err; > > > > > > If there is getting much special on certain pins between SoCs, and > > > then we can consider creating a desc->flag to split logic. > > > > Yes,SMT unnecessary for these kinds of virtual GPIOS pin in the path,if > > do it as > > err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, > > MTK_ENABLE); > > if (err && err != -ENOTSUPP) > > return err; > > I wonder if system will lose -ENOTSUPP information when smt was not > > successfully set by real gpio? > > -ENOTSUPP shouldn't happen in a real pin as SMT is supposed to be > supported by every real pin. > > If it is not true or there are more special on certain pins, and then > we consider to add a flag to struct mtk_pin_desc to group these pins > with their characteristics and to split and reuse the common code flow > with the extra flag. > > So for now, I thought it's enough to handle your case with adding a > few well self-explained comments for the exclusion condition. These > words help us remember we should add adding an extra flag to pin > description as one of TODO if more needs like you come out. > Thanks for your advice,I will update new patch > > > > > > > > > > > return 0; > > > > } > > > > -- > > > > 1.7.9.5 > > > >