Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Rafael J. Wysocki" <rjw@rjwysocki.net>
To:     Kevin Hilman <khilman@baylibre.com>, Thomas Meyer <thomas@m3y3r.de>
Cc:     khilman@kernel.org, nm@ti.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.
Date:   Mon, 17 Dec 2018 12:45:53 +0100
Message-ID: <1792812.5VpxBR0bW8@aspire.rjw.lan>
In-Reply-To: <7hy38vuc8e.fsf@baylibre.com>
References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> <1543760930051-514988180-4-diffsplit-thomas@m3y3r.de> <7hy38vuc8e.fsf@baylibre.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tuesday, December 11, 2018 7:53:05 PM CET Kevin Hilman wrote:
> Thomas Meyer <thomas@m3y3r.de> writes:
> 
> > NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> 
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> 
> > ---
> >
> > diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
> >  
> >  	if (sr_info->autocomp_active)
> >  		sr_stop_vddautocomp(sr_info);
> > -	if (sr_info->dbg_dir)
> > -		debugfs_remove_recursive(sr_info->dbg_dir);
> > +	debugfs_remove_recursive(sr_info->dbg_dir);
> >  
> >  	pm_runtime_disable(&pdev->dev);
> >  	list_del(&sr_info->node);
> 

Patch applied, thanks!