Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2588407imu; Mon, 17 Dec 2018 04:42:26 -0800 (PST) X-Google-Smtp-Source: AFSGD/VZ6CAyf+Qnwp5MThMHv7+41qk5wsaAEUZc0Hipcjezr6Xfv5KGpbDHgZCW66Q0xGd9NIgx X-Received: by 2002:a62:9683:: with SMTP id s3mr12670614pfk.60.1545050546888; Mon, 17 Dec 2018 04:42:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545050546; cv=none; d=google.com; s=arc-20160816; b=HALUyWYrWofM2jTBvxFFmp9sobn/gPXmJbRKQnehlRNZ6Xz9TuMld8+1/8EolmI1tD Ik3TBkmOwXfQbox6dOe3MMZs9rnr4ykc52hlsZyJHAaaO8XQ6ZU+m6RnRpZtX4dvorGY E28v+8lLSyOAVLdqp+JO0DSSxQ1RkDT/GpZnUAZSTaN6McSNFlc3EeHL7NrKKZ8mTyjG M2yxfpPIyHeQgHq7rPn1Kcr5zOPdArJw6ojklwq2msSeU/dK/djPVJmVx0DXK+zuSC7L IZF3jDkW1wDgtFLVhVkKGrmOUaM4Zf6oaYyXbr1Xihy3bsSBHd+asPh+0hpp972OUoNn 5duQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xihyMjJoYaLX1GtJ/bH88LS7/ynUElI1VIMjy+myuh0=; b=It/7qN9WEu0BwQ4+et9RCEY7WcftfGWcHHqikGwdUXrUuO3i81LKy8pQZjK5Zcgz76 /9inUA6lRLNqUwWfuPX46NlbYp4fpgSAyM50PUNWJZO8zLtoFyRoqusYARbfacYnoty1 EPsGwRnJReGhN73XTjnOvRyzZFVJ5CXL+hIGHhiJJJAXWiXs7Uh0vhJm8hVrcZwspJZ4 +NovvKn4ZrJIecJwMDtXe+tEfgOXeHLI1x7bo2X52qq0I7XeCjaYSmeJ7or7IOgqcsWn 4J/xKeAX//FBTv0Ohho/ErceLL5yt2Qngeo4CJSZOta4aua4SHn1KOebC+qOuVZD6O1p xrgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d37si10763976plb.140.2018.12.17.04.42.12; Mon, 17 Dec 2018 04:42:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732806AbeLQM2P (ORCPT + 99 others); Mon, 17 Dec 2018 07:28:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:60974 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726938AbeLQM2P (ORCPT ); Mon, 17 Dec 2018 07:28:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6B6CFACA4; Mon, 17 Dec 2018 12:28:13 +0000 (UTC) Date: Mon, 17 Dec 2018 13:28:12 +0100 From: Michal Hocko To: David Hildenbrand Cc: Gerald Schaefer , Mikhail Zaslonko , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel.Tatashin@microsoft.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Subject: Re: [PATCH v2 1/1] mm, memory_hotplug: Initialize struct pages for the full memory section Message-ID: <20181217122812.GJ30879@dhcp22.suse.cz> References: <20181212172712.34019-1-zaslonko@linux.ibm.com> <20181212172712.34019-2-zaslonko@linux.ibm.com> <476a80cb-5524-16c1-6dd5-da5febbd6139@redhat.com> <20181214202315.1c685f1e@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 17-12-18 10:38:32, David Hildenbrand wrote: [...] > I am wondering if we should fix this on the memblock level instead than. > Something like, before handing memory over to the page allocator, add > memory as reserved up to the last section boundary. Or even when setting > the physical memory limit (mem= scenario). Memory initialization is spread over several places and that makes it really hard to grasp and maintain. I do not really see why we should make memblock even more special. We do intialize the section worth of memory here so it sounds like a proper place to quirk for incomplete sections. -- Michal Hocko SUSE Labs