Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2739376imu; Mon, 17 Dec 2018 07:05:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/XuFx29LaatkPtA2FwQN9Y0ez4ilw46b1knjw9NpAiTK/flzUfhmdb3RsZxW/UdE9Ony2OT X-Received: by 2002:a62:4e49:: with SMTP id c70mr12976578pfb.167.1545059127608; Mon, 17 Dec 2018 07:05:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545059127; cv=none; d=google.com; s=arc-20160816; b=kP/c88v/fvmdj3pYEObM3oDm+h66txIw9H7S6oEysycW08RNpavBos87xol8Cr6nUz oVgAerm4ns41WoEzMyv9Dkj6zeMp9zurP9LjmfPa9aly3EVAVIFbOI3kMkNm4Aamd8+I qLEY3aC607DsN2ZTW2tb0/OGG3gX/Nsaaz8r8WI0Lem+vRhM7hIz9cK7mRszEa284SSq pMBBobKVFnaN+hw4SXYRkwBQ/TgKVXhGChMzOCEP97Hl803WfMNHxE3B5Zzk953BDzcR xCwZgHZLaomzuALi5V9p/EEA9VXw0lKd12BnO0bzsPtxB8XyY2Fm0Bjr7Wv3U+qp4Osj NJrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JFd7URq0llOGke76fCy+2bqc7mubARIMKrmA5Dkc37o=; b=pcea3kSsjqrXXWWnB4s8rXIvXbW1yfvxeVYc4N0dVbLoYXUp2Ri/WGn6LLm06qbASN +qbtoRPmfqg4kOE6+A0Jd/NV6nK/fy7tgGkKeEAraQK+iwhOOGnA6X+TsshaAp7zkcnR JbxPIw5a7avgkptVL0quy4nKsEK8BfBcMifhSIcVGX6QbS+HKw28nvbEA5k7jM6fPifo LhItJXrgX6IutKpRyNmqqljZu9vCCEE3B0Q9xMJlCWHTpScoZmTy/UF+wOqrS21SUvhq bUGVvHHMKy0zm1JZf24FDLkhLzd/5pWgAEtwZJDWCoCGTHWvYibuAHoZ9WQ1WRFeUdW6 V9Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bukem4ic; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19si11048622pgk.163.2018.12.17.07.05.11; Mon, 17 Dec 2018 07:05:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Bukem4ic; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387778AbeLQPDN (ORCPT + 99 others); Mon, 17 Dec 2018 10:03:13 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:39740 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733222AbeLQPDM (ORCPT ); Mon, 17 Dec 2018 10:03:12 -0500 Received: by mail-ed1-f68.google.com with SMTP id b14so10996574edt.6 for ; Mon, 17 Dec 2018 07:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JFd7URq0llOGke76fCy+2bqc7mubARIMKrmA5Dkc37o=; b=Bukem4icLQvt/EAhklo+J6GlxGB/wTn6rAoJBhYOXprIOyNSzzTvExDh6dhzl3AL/2 cE59A2C6/IMTairvDbb/hvUxL8+S4b21J6bVokTtOd6yAcXXoAAvm4PClPacP65OGQlS 0TjNXaZCQMWpsc1IlIVktzkDO1JmNdEGJdAa5ePrflXfFogEBVOn9mShQbb2AbJn1IZj 0qunrWuYkKH/kzpm2oYpvN2bCWKr9GpprQCYW5Te+oKorXdv3RnYZxNvAfQG5z5451g9 BONFHQLJU2NsqkilneRdSQ0zEjul8XuPZqaSupww6CCg6y5/AvF2skiJhss0etZ0TWuF LzBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JFd7URq0llOGke76fCy+2bqc7mubARIMKrmA5Dkc37o=; b=pKr1onMVoXfUkb3IFkiNwtQhd1e0gb8YU3e4KhTzNl95RBkhL93aNaZvHXYutmB0Xa RF0wq4Z2SpZB3iVgawjnLVHkIOgZDE/eWChagPRpHm0AIGzAp7Gn84R3PhMbLlYnz8HM 9QpZVFXSBg1MjCJadLJi0bE12nN8H0jtKIDy6x5QAlJZSCNgEgxB6KxEWt6aFeVpI6QK BleII714dJ0LXoxDgQBCMiebi1gBAgOqE8jAYguvJHLzJ7SplxGv99P32hAu1isu3LvI gWtMxxN4tY6SUx0PPGVNjMIoDO7uhStweSGeG/U9pythBvECZRwVHdna3DBHupzni9+4 5Lhw== X-Gm-Message-State: AA+aEWZUcNx0I4WfmitHRvR/pqiszHZTijVi3fyp3mLVbq1O4CnqRl4n vNVWKXVPgiUB5WCWerYH7Jg= X-Received: by 2002:a50:f19b:: with SMTP id x27mr13486623edl.140.1545058990104; Mon, 17 Dec 2018 07:03:10 -0800 (PST) Received: from localhost (pD9E51040.dip0.t-ipconnect.de. [217.229.16.64]) by smtp.gmail.com with ESMTPSA id o6-v6sm678996ejs.32.2018.12.17.07.03.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 07:03:08 -0800 (PST) From: Thierry Reding To: Jassi Brar Cc: linux-kernel@vger.kernel.org, Caesar Wang Subject: [PATCH v2 17/19] mailbox: rockchip: Use device-managed registration API Date: Mon, 17 Dec 2018 16:02:15 +0100 Message-Id: <20181217150217.32435-18-thierry.reding@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181217150217.32435-1-thierry.reding@gmail.com> References: <20181217150217.32435-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding Get rid of some boilerplate driver removal code by using the newly added device-managed registration API. Cc: Caesar Wang Signed-off-by: Thierry Reding --- drivers/mailbox/rockchip-mailbox.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c index d702a204f5c1..f24a77b1a0ff 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -247,28 +247,15 @@ static int rockchip_mbox_probe(struct platform_device *pdev) mb->chans[i].msg = NULL; } - ret = mbox_controller_register(&mb->mbox); + ret = devm_mbox_controller_register(&pdev->dev, &mb->mbox); if (ret < 0) dev_err(&pdev->dev, "Failed to register mailbox: %d\n", ret); return ret; } -static int rockchip_mbox_remove(struct platform_device *pdev) -{ - struct rockchip_mbox *mb = platform_get_drvdata(pdev); - - if (!mb) - return -EINVAL; - - mbox_controller_unregister(&mb->mbox); - - return 0; -} - static struct platform_driver rockchip_mbox_driver = { .probe = rockchip_mbox_probe, - .remove = rockchip_mbox_remove, .driver = { .name = "rockchip-mailbox", .of_match_table = of_match_ptr(rockchip_mbox_of_match), -- 2.19.1