Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3036695imu; Mon, 17 Dec 2018 12:06:48 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vx6FgOHlKGqRQyJ/iYi+4hUFQsDwWoIgrmNf80mtZG3vOO0+3JVaL7MR0tk5VxKbiyYtmo X-Received: by 2002:a62:2606:: with SMTP id m6mr13697688pfm.133.1545077208881; Mon, 17 Dec 2018 12:06:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545077208; cv=none; d=google.com; s=arc-20160816; b=QGRtBQOvcIqYM3Og1lhErsShcQcHXdBVBjDAIwrVHcFKmY2caEUCHuJunq0Hty4+8Y FHvpQzcrz41vAv7BAKypFW7WKUr5dvTfDqRwAR0NaCZoiLW4KH6px60a0tyA3vnldMv4 MgsOgvpQd+qKV5N7r7KbhPCCuLHPe4tF8GWTgCDQzMrpecpmefFbbR3KjxV1u+eKEgWO e2glfTXzpJjP06EXIx+z5M84zPHcfyZyuvISyaPdRDLBVn+SZVti6wKFzkQz40sJYbAY v/4biHjShZ9teuwtmxl37Ck00x/6YOI7rsu4Zrsjk6HvdAD0gS8vmm+mN0RI/OBkqhsm Maxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3gnHnu/b7X8Z/EqkilLx4vCcIK24VR9A6tqq49rKRGU=; b=Dz+ndxkksOMFwUkBY7Iztjq+jSR28HUrlMmXTRYQWJFRr3GHNiOKAz9Qe9pK5N8hKo i+GDOEHYvlKrLAvlFco+8JhkwpOhPTl3bBb24EVwqjCmx7LxP4ZIRMPCMDhKHxa5ccBP +kmPpx4Jl+oz1vuu835h+8u/TGQpBBNdD4r1U5b5lDNtivDqFCKGjBsYlB4fUF4+gs0r B3uoBnvyuQepyngJgsSbk4ZmGYZqFkz6oHBU0rf9TeDgxpVBXNtCMdwrNOBlCQSOf1Kw tSph1sJ+J5ARzdtpmh80QtydRPmMnHKZhcEDmmi6uoX5ZyF+494+awWpvTMCuOPu6ub0 pNnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WbTAbZmy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 187si12981063pfb.41.2018.12.17.12.06.31; Mon, 17 Dec 2018 12:06:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WbTAbZmy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388900AbeLQSZZ (ORCPT + 99 others); Mon, 17 Dec 2018 13:25:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38520 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727760AbeLQSZZ (ORCPT ); Mon, 17 Dec 2018 13:25:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3gnHnu/b7X8Z/EqkilLx4vCcIK24VR9A6tqq49rKRGU=; b=WbTAbZmyXpc17Hx3eTWkRkWP0 eUXe63grA4wO6KU6DZPKonkqAq4jj6WDcLYpfUKWhT1YiUIOxB/fdB0ZXyCzvaYNWUiBoWsQDFQBv EN6SxsauVDt6oH8F0jYaOANoosugcsH1apQuQIMMNC7DL/UJNIfnndpt5N+xpkNKUMe15LsQSMwGs xfUl0M6Offaf7NnXuz/XOFEKupAZOmsuCcnO1xPn7dKIqgKCL2jLvW3LaINxtTIAcMpKiQgNqyjJw zvcdPgyl3wRfT+C6cWJSxKa5B/e0qbwUObfSvWpp8Akg5Cp2+Oj+GGImxW6qjAQ4ANkzVkpWrLeks +d1B5zDqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYxZw-0003iV-Ar; Mon, 17 Dec 2018 18:25:20 +0000 Date: Mon, 17 Dec 2018 10:25:20 -0800 From: Christoph Hellwig To: Anup Patel Cc: Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Jason Cooper , Marc Zyngier , Christoph Hellwig , Atish Patra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] irqchip: sifive-plic: Pre-compute context hart base and enable base Message-ID: <20181217182520.GB7086@infradead.org> References: <20181130080207.20505-1-anup@brainfault.org> <20181130080207.20505-2-anup@brainfault.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130080207.20505-2-anup@brainfault.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 01:32:02PM +0530, Anup Patel wrote: > This patch does following optimizations: > 1. Pre-compute hart base for each context handler > 2. Pre-compute enable base for each context handler > 3. Have enable lock for each context handler instead > of global plic_toggle_lock All of which is pretty obvious from reading the patch. The big question that needs to be answered in the changelog is why you do that.