Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3097252imu; Mon, 17 Dec 2018 13:16:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/VysMwcSvXUVTNOp5LgvSB2KLygq1cT+3ZcwNNEeg0voTrVGc5Hc0d6hZcsPqMSfkLPM10l X-Received: by 2002:a65:4784:: with SMTP id e4mr13147985pgs.12.1545081377651; Mon, 17 Dec 2018 13:16:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545081377; cv=none; d=google.com; s=arc-20160816; b=k9ypG64GBMdUSD0tJ+sQ9zdN1atQO7QY3/j2+cYEdoJv187oQtnkVijIluFRRBbNVa 9Aa7OlL/cyyvjLfMYYz5PfTWDtTVRwgeN6tEznR+gZLrnzzHpDLbjd12cl1Lx2Il5FgY 9TCm1BSYMBWsq56YW/9wTlt/5l0GTVAsz/XfcszmnE14jZkniqFrHUr8aZeUncIMjwuu JIKFTHDASGms/7DBUPF/gczqKV4N9s7glJjde2F6q4ZYRjuV5vAJxCM32JP7V/tmTSG9 oUjBQfeDAAn5FmRHwfkSWOeMj3ziy9HJF6TmhaL8ntHuhx8ujqXCHDhMCMY2pV9K6l8h +4YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6AgDmzoxlwfYO3E3FfNbM/qMUiM2v65TmXBk7SuPY7I=; b=P4QHlkoxmpa9HazFq7HWLXbT4hKm6fvbriCjovxG7o7UBmFSmW2x/dDngaqmZnv45N /U6VJgu2mjbCC0oMPvsGqC1udwt3CXaqV6xzkcubo/XQgyi2eBMx/TxLNj4YJ+Hy689C PYi8z/J/h+XpOrQi1QcvDo+Ud+SNukB0DrtfJum6phDwNoi95ez3REq8QdxuT+F72pRL WMmEvqpik9BqNUzmJMK55YNFf3SqRWN5kmrUap/RKsEi4nJu+ORWmhyjkeTcQVMQR4Ms MC/yyilAC5QqePHVt8IXrVEbXClZUwBFm43165E2fRsQ7oUjNl09LeweiC4LYk9h6DFg 4jPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=RuE8Du49; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si11920751pfd.154.2018.12.17.13.16.02; Mon, 17 Dec 2018 13:16:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=RuE8Du49; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387574AbeLQUff (ORCPT + 99 others); Mon, 17 Dec 2018 15:35:35 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34786 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbeLQUfe (ORCPT ); Mon, 17 Dec 2018 15:35:34 -0500 Received: by mail-pf1-f196.google.com with SMTP id h3so6949485pfg.1 for ; Mon, 17 Dec 2018 12:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6AgDmzoxlwfYO3E3FfNbM/qMUiM2v65TmXBk7SuPY7I=; b=RuE8Du49uLfmRj0sjDzWf6vAd3GD+ThkejmeSWVi0ycwQWwvpYXVCyzQZT4U3M5Wts KBeMSqXKroR3bN5Y7g9TVHxugvW3/5eFN2YGkTijUBLYv1XwIyNLGVfKr39jOqXFbx81 2Jmsa0F0aL6hBscT3o/9NWcQoFaN1yZIwtNmfZFD6/waDkRtFzVgsNnX6rKdxTXam1Tn QcnxeqnXTP6DIvy4XZo2KnNQAXoW/6I+Oeg41Wn05FZwg4a+z5sJ6dRnMpvxR8uuyHFc 1Qb1Iu43OdKxGT4Oh6fGCW2uCsCshwEVc8CGbekMxnHTBK4mrGEIGF09DyMRl8KFtZM0 lHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6AgDmzoxlwfYO3E3FfNbM/qMUiM2v65TmXBk7SuPY7I=; b=n6lgxyZMuPg/bJavVOQrN8cDAG3ttXkza/5WqKTP8J226IXDBEE86P5K+8dluvg3Ob lsRQCNerzu7Ii/BMVUSbimaVvZ0VHwsDBAZIHdsf3yG4+3MSEcnl7k8JlhRmRifjseTZ lNW+zS/baebInTGXfJqecZ3NETtu58/02pFAy+lY5l8sz4HKVtJ93wd43R4DADYxO2vJ cXVc1NbLk3rvzwa78z+0Jbqk6Uq4945yN2JGojXg21qcD/ODeP4dEhXHuZAn0Ylw0zCp CvcVT+FRdKLbacWItzJTx0Hk/Z0jdXJ/lhRrRvIO3YkE3Lu4bZP2nLr2RGK25h6O1459 J1Ig== X-Gm-Message-State: AA+aEWYvTyHLoQkf2GPsPqI1MRwnsC2ao/JXI3t1oivA1GWFJtKfQfcO BcB2qX6bIUCVq8ijMYoIF4EshA== X-Received: by 2002:a63:cf48:: with SMTP id b8mr13541348pgj.17.1545078933761; Mon, 17 Dec 2018 12:35:33 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j21sm18531113pfn.175.2018.12.17.12.35.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 12:35:33 -0800 (PST) Date: Mon, 17 Dec 2018 12:35:31 -0800 From: Stephen Hemminger To: Dexuan Cui Cc: "'olaf@aepfle.de'" , "'gregkh@linuxfoundation.org'" , Haiyang Zhang , "'linux-kernel@vger.kernel.org'" , Michael Kelley , Sasha Levin , "'apw@canonical.com'" , "'devel@linuxdriverproject.org'" , vkuznets , "'jasowang@redhat.com'" Subject: Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels Message-ID: <20181217123531.71a4f3d4@xeon-e3> In-Reply-To: References: <20181217091518.5004d4c7@xeon-e3> <20181217101703.78e8bb3f@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Dec 2018 18:44:12 +0000 Dexuan Cui wrote: > > From: devel On Behalf Of > > Dexuan Cui > > Sent: Monday, December 17, 2018 10:31 AM > > > From: Stephen Hemminger > > > > > > The old code was risky because it would silently return stack garbage. > > > Having an error check in get_debuginfo would eliminate that. > > > > OK, then let me make another patch based on the latest char-misc-linus. > > > > -- Dexuan > > Hi Stephen, your patch can apply cleanly. Let me rebase your patch to > char-misc-linus, do a test, and then post it with your Signed-off-by and mine: > I assume you're Ok with this. Please let me know in case it's not. :-) > > Thanks, > -- Dexuan Sure.