Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3101706imu; Mon, 17 Dec 2018 13:21:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/VcsFJR1UyEJYe5TOlRrt+rwM+DOztS5vONAq+24B8C32mXtyonrQtNTPBpo5febVRxAhXr X-Received: by 2002:a63:6006:: with SMTP id u6mr13486434pgb.176.1545081675698; Mon, 17 Dec 2018 13:21:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545081675; cv=none; d=google.com; s=arc-20160816; b=ZNffOJBeppeFsBVoRXo9HJtAwZJiMU7M1sTilmWucfT5DgTqQReBRiGOHqrG3xopxd AOoO4Pw6fCJKHxA7b7ImYooG2P8n90XAN48PdXjtzv8xjo1k3Cy2R0qVaq/xsIj+8YWL x82BeQpaMrJh7MHURscp6kU0zS6sB0NbMnPDMUQVYB/t6Ix6+VF+PdJN99nv5OdeG8yr +b2m28fLubbYBTUvFtMlG3EBb+ZRvb62mdgaXl2DNP8VSjIuBN7oNBafUxk9BhQz8KkL LuPpe6u7+6aBl31MPjt2k7HIof1PBB8NDPDCfncHELd5fdoUyupYc/yCROBNO7zPW3Pb /jnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=BL2wIN7ZZyCWNOSfo4FtZVdBgOrzgB+sCCUqJOcpMo4=; b=mHaSvUln2RX48Og4wnfZVy6sMaejK0m0bx3vpUOrLVGKY9G56f3LDnfDkRjLlagD23 jlvXiKDeMVUkyxrcZxyn0R3wwCShzBySszt3jfnVoZggM1jLyHkMQT+EqRzEsEcOZY/l u5D+jyDBTOb1NOZH/ao13vx5bMSBsKPLbg2xk2Sq4jX2PnNQ50zrlD4gE1p12OxprB8y mB5LUK9iic5UJVPpelXWPIxZspPOs8b0qQddurC4hipM+RG283Q235rGWd6EFXg/7W5y k8cQzk7Te97dA+fD7Nnrf+qtMSaSZuRRoYCbfqvauGVgLtQvsBZDFIS+nXB1xypTne1V NTwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si11336153pgc.237.2018.12.17.13.21.00; Mon, 17 Dec 2018 13:21:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733201AbeLQUuK (ORCPT + 99 others); Mon, 17 Dec 2018 15:50:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50240 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbeLQUuJ (ORCPT ); Mon, 17 Dec 2018 15:50:09 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E0389AF7; Mon, 17 Dec 2018 20:50:08 +0000 (UTC) Date: Mon, 17 Dec 2018 12:50:01 -0800 From: Andrew Morton To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , linux-sctp@vger.kernel.org Subject: Re: [PATCH 6/7] sctp: Convert to genradix Message-Id: <20181217125001.8e89ac2565417d55ef7a624e@linux-foundation.org> In-Reply-To: <20181217131929.11727-7-kent.overstreet@gmail.com> References: <20181217131929.11727-1-kent.overstreet@gmail.com> <20181217131929.11727-7-kent.overstreet@gmail.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet wrote: > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, > goto out; > } > > - stream->incnt = incnt; > - stream->outcnt = outcnt; > - > asoc->strreset_outstanding = !!out + !!in; > I'm seeing a reject here for some reason. Using todays's linux-next, but there are no changes against net/sctp/stream.c in -next. The assignment to stream->incnt has disappeared. I did this: @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as goto out; } - stream->outcnt = outcnt; - asoc->strreset_outstanding = !!out + !!in; out: We're at 4.20-rc7 and this series is rather large. I'll merge them all to see what happens, but I don't think it's 4.21-rc1 material?