Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3103540imu; Mon, 17 Dec 2018 13:23:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vrdw+d72Cf8VfX3mHG8N/7g1MJNvvCfHT6ybHq9G7Apu9Np5n9dXieEQ+N6FfMd7129kjU X-Received: by 2002:a62:e0d8:: with SMTP id d85mr14017323pfm.214.1545081809418; Mon, 17 Dec 2018 13:23:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545081809; cv=none; d=google.com; s=arc-20160816; b=SvzOFMZu34FuCYlMw3GPE6e8iWOn5/EsPx1ysDOcHvfRUYWL4pCUwpXfYIpFOUDGA9 mgCMI/fOnZ3qyAYxPCdomd7SUxBGtIF1gpqnhpdGnbv3PdlTKACTqCKbJdSCYHxb1clK /VytAWaCy+2d3GUKHZtNHnWdtKbCxuWMejCsjMAza/FzM3tXZQIdtmMlbIaU01wLnCUw 8N646AapEdVrtlGwvuVhxRmPJZCZGwIWzY2rcDyCBx/8mh0CJURdiv6gjf2AB5SdPfWb 0EdchBIP+gxMWDkF2lSDWbNHgr13ClSUTyZGpY/94uqA9n1cOIMsDZYlMuOoBzvjOBnm v4pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mruqpFEP+l2KI3ZHPXZSXxBKXgVGPFVtHAOD+cXuvrM=; b=EXXDkh+dx67SF+Mx9spE/QqW08Qq9To1yJKyqDAwOWbWdRf8TYZZUafjbejdZK4LPc IK+kwlJCUE6pqnX8o1cBRXrsoVFAx1BbsKWAOHzExRksguoA5ajU6xLdFwhH32bTYQoB QMk2o8LtySrppm9031F9Lb4KHVirer1xbMaErp/WahBCGi704myjtWDeaKaH/EBE3e2m JbPg7prUGmbRHjUPd4dizGxup2gtbN5hS13HBgzc73lSgsWobltvMfEl5ep2UdWnIB9k Sc29ae8Iqip/e/PXHM2OY+H9U9aj8OMS8LvqSjoqhhVfn11FW6Vf2LOJ4fQrb5a0bJlT JBcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h96si12094171plb.230.2018.12.17.13.23.14; Mon, 17 Dec 2018 13:23:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389319AbeLQVDg (ORCPT + 99 others); Mon, 17 Dec 2018 16:03:36 -0500 Received: from mga12.intel.com ([192.55.52.136]:55417 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388589AbeLQVDe (ORCPT ); Mon, 17 Dec 2018 16:03:34 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 13:03:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,366,1539673200"; d="scan'208";a="302953560" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2018 13:03:34 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 30335300B49; Mon, 17 Dec 2018 13:03:34 -0800 (PST) Date: Mon, 17 Dec 2018 13:03:34 -0800 From: Andi Kleen To: Josh Poimboeuf Cc: Arnd Bergmann , Peter Zijlstra , Linux Kernel Mailing List , the arch/x86 maintainers , Steven Rostedt , Miroslav Benes Subject: Re: objtool warnings for kernel/trace/trace_selftest_dynamic.o Message-ID: <20181217210334.GW25620@tassilo.jf.intel.com> References: <20181217173900.ygifx7khwmzn2gv2@treble> <20181217180434.GS25620@tassilo.jf.intel.com> <20181217181638.dfexg6mkmbfyzfli@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181217181638.dfexg6mkmbfyzfli@treble> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > That seems weird. > > > > Are you sure it's not just because they are empty? AFAIK > > gcc doesn't necessarily generate frame pointers for empty functions. > > I suspected that it was because they're empty, however I didn't see this > warning for other leaf functions. The sancov plugin is presumably > taking care of adding frame pointers where needed. Also, adding That would surprise me. > -mno-omit-leaf-frame-pointer didn't fix it. > > And anyway I confirmed that it was fixed by removing __noclone. So this is with a plugin? Maybe the plugin does something wrong? I thought this was just a standard build. I'm not sure the problem is well enough understood yet to really do anything. Do you have a simple standalone test case to show the compiler behavior? -Andi