Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3203766imu; Mon, 17 Dec 2018 15:26:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/WFS8wd7dQvNu0NaEssNOV4WZtNbL4tOjC/qxQ5SeNWN2oX86I9x9WKuJfZNT+UzBGM7deK X-Received: by 2002:a63:7c6:: with SMTP id 189mr14082741pgh.129.1545089178326; Mon, 17 Dec 2018 15:26:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545089178; cv=none; d=google.com; s=arc-20160816; b=ti7QChYjA1QAwnXSjN5WYaJr/7IPl+1RMoVwq1WVJj2wwl9MGvAyhkRze/KquwvV4r kINfG7ZXLFICxWtUaYfPzrokKjaOQtKV5ztppsw99La3tLpbT4QKXtBTF945AP/qi9pk VN8ONRdcHeppEfR53/oKzrcIaJ89qMIRwZaiz9IOqjv9foh1u2RoSUnqS9KIR9TSaJm0 8X2v/W62JdLQU61fE1Q6N8Tkg/7nzXia/s+SgckSRiWK14WWQ7a/JuMbyRoSBmd2ZsCA rQmc1+BmE8NaQs6Apc5G61FaBNylLGuq2H2KW2sKQRn0CQtZTzP8vzDz6ry+zu1XocHe x36w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=hrUZfMxYGC0/YtU26vWVzV1eA7IHB7dz/0zYlnZT4Ig=; b=q1Bsv9FNCdUhFdJWsDQWeBn1AxdSrnDZxqimxxKVsPM0jZj9yViFAj0JWui+ptSjGH 7mTh8Jx/WZX+wmjB+PGvkqhogWMrEXNSyzyaz5Mnzgf4NGjdhPwp21f4iQlyUj5OzyW+ rwDYRq+ll1HXw5CIvarHJGJZVOUgP+5TiM+MTzFSXHhvQnwG3OXDBt2H210faaw8qGz7 ETwXdlrrXm24lJodzPeQHburgBgQre5GSqVL3u4KupIBQnJf9zLQqU2LcBxtxkpiYYl8 dBP0Ea0qkaMg0zZQyQlZsOe16AlgMmSbcBvpTbiatNl8y31FxC2lqkDVgVtBxJKaOl7G BwCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si11737157pgi.388.2018.12.17.15.26.03; Mon, 17 Dec 2018 15:26:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbeLQXH2 (ORCPT + 99 others); Mon, 17 Dec 2018 18:07:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59976 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbeLQXH2 (ORCPT ); Mon, 17 Dec 2018 18:07:28 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 36707B5E; Mon, 17 Dec 2018 23:07:27 +0000 (UTC) Date: Mon, 17 Dec 2018 15:07:26 -0800 From: Andrew Morton To: Oscar Salvador Cc: mhocko@suse.com, vbabka@suse.cz, pavel.tatashin@microsoft.com, rppt@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm, page_alloc: Fix has_unmovable_pages for HugePages Message-Id: <20181217150726.6eea4942005516d565dae488@linux-foundation.org> In-Reply-To: <20181217225113.17864-1-osalvador@suse.de> References: <20181217225113.17864-1-osalvador@suse.de> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Dec 2018 23:51:13 +0100 Oscar Salvador wrote: > v1 -> v2: > - Fix the logic for skipping pages by Michal > > --- Please be careful with the "^---$". It signifies end-of-changelog, so I ended up without a changelog! > >From e346b151037d3c37feb10a981a4d2a25018acf81 Mon Sep 17 00:00:00 2001 > From: Oscar Salvador > Date: Mon, 17 Dec 2018 14:53:35 +0100 > Subject: [PATCH] mm, page_alloc: Fix has_unmovable_pages for HugePages > > While playing with gigantic hugepages and memory_hotplug, I triggered > the following #PF when "cat memoryX/removable": > > ... > > Also, since gigantic pages span several pageblocks, re-adjust the logic > for skipping pages. > > Signed-off-by: Oscar Salvador cc:stable?