Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 2/2] trace nvme submit queue status
To:     yupeng <yupeng0921@gmail.com>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        keith.busch@intel.com, axboe@fb.com, hch@lst.de, jthumshirn@suse.de
References: <20181218045138.4282-1-yupeng0921@gmail.com>
 <20181218045138.4282-2-yupeng0921@gmail.com>
From:   Sagi Grimberg <sagi@grimberg.me>
Message-ID: <24f78f57-9786-effd-6ffe-f9a556211898@grimberg.me>
Date:   Mon, 17 Dec 2018 23:26:23 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181218045138.4282-2-yupeng0921@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> @@ -899,6 +900,10 @@ static inline void nvme_handle_cqe(struct nvme_queue *nvmeq, u16 idx)
>   	}
>   
>   	req = blk_mq_tag_to_rq(*nvmeq->tags, cqe->command_id);
> +	trace_nvme_sq(req->rq_disk,
> +		nvmeq->qid,
> +		le16_to_cpu(cqe->sq_head),
> +		nvmeq->sq_tail);

Why the newline escapes? why not escape at the 80 char border?

Other than that, looks fine,

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>