Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Hennerich, Michael" <Michael.Hennerich@analog.com>
To:     Paul Gortmaker <paul.gortmaker@windriver.com>,
        Lee Jones <lee.jones@linaro.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 02/18] mfd: adp5520: Make it explicitly non-modular
Thread-Topic: [PATCH 02/18] mfd: adp5520: Make it explicitly non-modular
Thread-Index: AQHUlkfQ5yy/j2MZdUW8lYUwz7mz46WEHeAw
Date:   Tue, 18 Dec 2018 07:43:14 +0000
Message-ID: <BYAPR03MB3573A8675B9FB8E436024AA18EBD0@BYAPR03MB3573.namprd03.prod.outlook.com>
References: <1545078688-21217-1-git-send-email-paul.gortmaker@windriver.com>
 <1545078688-21217-3-git-send-email-paul.gortmaker@windriver.com>
In-Reply-To: <1545078688-21217-3-git-send-email-paul.gortmaker@windriver.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: analog.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa3dbf2-2863-465a-0503-08d664bc77a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2018 07:43:14.1702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3752
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Paul Gortmaker [mailto:paul.gortmaker@windriver.com]
> Sent: Montag, 17. Dezember 2018 21:31
> To: Lee Jones <lee.jones@linaro.org>
> Cc: linux-kernel@vger.kernel.org; Paul Gortmaker <paul.gortmaker@windrive=
r.com>; Hennerich, Michael
> <Michael.Hennerich@analog.com>
> Subject: [PATCH 02/18] mfd: adp5520: Make it explicitly non-modular
>=20
> The Makefile/Kconfig currently controlling compilation of this code is:
>=20
> drivers/mfd/Makefile:obj-$(CONFIG_PMIC_ADP5520) +=3D adp5520.o
> drivers/mfd/Kconfig:config PMIC_ADP5520
> drivers/mfd/Kconfig:    bool "Analog Devices ADP5520/01 MFD PMIC Core Sup=
port"
>=20
> ...meaning that it currently is not being built as a module by anyone.
>=20
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>=20
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>=20
> Since module_i2c_driver() uses the same init level priority as
> builtin_i2c_driver() the init ordering remains unchanged with
> this commit.
>=20
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>=20
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>=20
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/mfd/adp5520.c | 30 +++++++-----------------------
>  1 file changed, 7 insertions(+), 23 deletions(-)
>=20
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index be0497b96720..2cdd39cb8a18 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -7,6 +7,8 @@
>   *
>   * Copyright 2009 Analog Devices Inc.
>   *
> + * Author: Michael Hennerich <michael.hennerich@analog.com>
> + *
>   * Derived from da903x:
>   * Copyright (C) 2008 Compulab, Ltd.
>   *	Mike Rapoport <mike@compulab.co.il>
> @@ -18,7 +20,7 @@
>   */
>=20
>  #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> @@ -304,18 +306,6 @@ static int adp5520_probe(struct i2c_client *client,
>  	return ret;
>  }
>=20
> -static int adp5520_remove(struct i2c_client *client)
> -{
> -	struct adp5520_chip *chip =3D dev_get_drvdata(&client->dev);
> -
> -	if (chip->irq)
> -		free_irq(chip->irq, chip);
> -
> -	adp5520_remove_subdevs(chip);
> -	adp5520_write(chip->dev, ADP5520_MODE_STATUS, 0);
> -	return 0;
> -}
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int adp5520_suspend(struct device *dev)
>  {
> @@ -346,20 +336,14 @@ static const struct i2c_device_id adp5520_id[] =3D =
{
>  	{ "pmic-adp5501", ID_ADP5501 },
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(i2c, adp5520_id);
>=20
>  static struct i2c_driver adp5520_driver =3D {
>  	.driver =3D {
> -		.name	=3D "adp5520",
> -		.pm	=3D &adp5520_pm,
> +		.name			=3D "adp5520",
> +		.pm			=3D &adp5520_pm,
> +		.suppress_bind_attrs	=3D true,
>  	},
>  	.probe		=3D adp5520_probe,
> -	.remove		=3D adp5520_remove,
>  	.id_table	=3D adp5520_id,
>  };
> -
> -module_i2c_driver(adp5520_driver);
> -
> -MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> -MODULE_DESCRIPTION("ADP5520(01) PMIC-MFD Driver");
> -MODULE_LICENSE("GPL");
> +builtin_i2c_driver(adp5520_driver);
> --
> 2.7.4