Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181126060802.19314-1-anup@brainfault.org> <CAAhSdy1danjgviJ2WGGEANQXFkzZzXUdCj+04dZ4eLjcVOt14A@mail.gmail.com>
 <587bbe80f25203e6122dfcc0eadba50b@mailhost.ics.forth.gr>
In-Reply-To: <587bbe80f25203e6122dfcc0eadba50b@mailhost.ics.forth.gr>
From:   Anup Patel <anup@brainfault.org>
Date:   Tue, 18 Dec 2018 13:53:23 +0530
Message-ID: <CAAhSdy2bxrP0VQui5AzEL5sueDACU9DkCN4h0--aC=8OpYKt8w@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Make BSS section as the last section in vmlinux.lds.S
To:     Nick Kossifidis <mick@ics.forth.gr>
Cc:     Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christoph Hellwig <hch@infradead.org>,
        Atish Patra <atish.patra@wdc.com>,
        linux-riscv@lists.infradead.org,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 17, 2018 at 6:29 PM Nick Kossifidis <mick@ics.forth.gr> wrote:
>
> =CE=A3=CF=84=CE=B9=CF=82 2018-12-17 11:36, Anup Patel =CE=AD=CE=B3=CF=81=
=CE=B1=CF=88=CE=B5:
> > On Mon, Nov 26, 2018 at 11:42 AM Anup Patel <anup@brainfault.org>
> > wrote:
> >>
> >> The objcopy only emits loadable sections when creating flat kernel
> >> Image. To have minimal possible size of flat kernel Image, we should
> >> have all non-loadable sections after loadable sections.
> >>
> >> Currently, execption table section (loadable section) is after BSS
> >> section (non-loadable section) in the RISC-V vmlinux.lds.S. This
> >> is not optimal for having minimal flat kernel Image size hence this
> >> patch makes BSS section as the last section in RISC-V vmlinux.lds.S.
> >>
> >> In addition, we make BSS section aligned to 16byte instead of PAGE
> >> aligned which further reduces flat kernel Image size by few KBs.
> >>
> >> The flat kernel Image size of Linux-4.20-rc4 using GCC 8.2.0 is
> >> 8819980 bytes with current RISC-V vmlinux.lds.S and it reduces to
> >> 7991740 bytes with this patch applied using GCC 8.2.0. In summary,
> >> this patch reduces Linux-4.20-rc4 flat kernel Image size by 809 KB.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >>  arch/riscv/kernel/vmlinux.lds.S | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/riscv/kernel/vmlinux.lds.S
> >> b/arch/riscv/kernel/vmlinux.lds.S
> >> index 65df1dfdc303..cc99eed44931 100644
> >> --- a/arch/riscv/kernel/vmlinux.lds.S
> >> +++ b/arch/riscv/kernel/vmlinux.lds.S
> >> @@ -74,8 +74,6 @@ SECTIONS
> >>                 *(.sbss*)
> >>         }
> >>
> >> -       BSS_SECTION(PAGE_SIZE, PAGE_SIZE, 0)
> >> -
> >>         EXCEPTION_TABLE(0x10)
> >>         NOTES
> >>
> >> @@ -83,6 +81,8 @@ SECTIONS
> >>                 *(.rel.dyn*)
> >>         }
> >>
> >> +       BSS_SECTION(0x10, 0x10, 0x10)
> >> +
> >>         _end =3D .;
> >>
> >>         STABS_DEBUG
> >> --
> >> 2.17.1
> >>
> >
> > Hi All,
> >
> > Any comment on this patch?
> >
> > Regards,
> > Anup
> >
>
> Just a note on coding style, you should be using a macro instead of 0x10
> so that those who read the code can understand what it is and also a few
> comments since searching through the commit logs to understand why you
> used it isn't optimal.

RISC-V can support 32bit, 64bit and 128bit machine-word sizes.

The 0x10 number is the machine-word size in bytes for 128bit
RISC-V CPU (i.e. maximum machine-word size).

I will add a macro MAX_BYTES_PER_LONG in vmlinux.lds.S and
use it in-place of 0x10

Regards,
Anup