Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3718901imu; Tue, 18 Dec 2018 03:05:55 -0800 (PST) X-Google-Smtp-Source: AFSGD/WhGkPZaPoRvyKmxnUinzZGW0lYAf/uYXsHRke8gpQIIBeLE0/bxlJ6RMzWeK5yD5o9lV6S X-Received: by 2002:a17:902:780c:: with SMTP id p12mr15595373pll.197.1545131155172; Tue, 18 Dec 2018 03:05:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545131155; cv=none; d=google.com; s=arc-20160816; b=ynCa+NSgH/ae3XSHJ/xbPWeIvj3O5mo07oXE2uYeU6p7rM7Iw7ljFNozxfEkNTQ5o6 UBYMXu6cZYX1oxo2wdEzFJqcQGKc/J58LjfE3VyXoeApXSuliOuab0lEGerGgFimOy0w CWzOppjHlgl/KVjif9msSnF3NyHnwDZywdXw6uKE3Vm7fEz/1d9BUQQ8eB78mUesdSxp P/IQ0gWJ9m31MHEoLix2H4Untb/0Oaa8ERZrM7O2drlzUaOZDD8i6iGEQ885miIVMkKx Lay+dzIruCkGvKdziQp6IF3bU57NJXXyrUDyq/c90zbnXVt3alPiSfgv7WmitDSIWh+n odYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=okmw1W7FoaLsgLGg9c0oz08xk2MemHV79CkP1Umb1Ow=; b=KO/8s+bj+ladBUjqH4dei/8QyqRl4UVKpuGGqF/t5Eierak28n2HBW67YWD15navhC mmu0e4GPRaZO+U8q0CF6CXjatTHNOQHU6rDyzuubedazM42gS4rxv43P6k/oyfsjN7GY G7e0be7Vb/PDHMNIXNrrjvSZnaRC2sDvXxowdzRKmdGjxCud4AN4t+b+tzGfryuGq0je DNyalycmYS1QLPm3r1n170GvfAmjHs9dKRfmrl01RdwjP4z0d5m8vyLAYCw5eRslPrcA RdpBHUwKD3SxLWdh2ddDYo5zckYDQH0kn7AAime5G89WjY5z/OXTVcUSt60nWCCgFm+A KE6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 82si12131172pfa.115.2018.12.18.03.05.37; Tue, 18 Dec 2018 03:05:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbeLRLCH (ORCPT + 99 others); Tue, 18 Dec 2018 06:02:07 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:38125 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726589AbeLRLCG (ORCPT ); Tue, 18 Dec 2018 06:02:06 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C9CC38B5B93D4; Tue, 18 Dec 2018 19:02:03 +0800 (CST) Received: from linux-ioko.site (10.71.200.31) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.408.0; Tue, 18 Dec 2018 19:01:57 +0800 From: Peng Li To: CC: , , , , , Subject: [PATCH net-next 05/12] net: hns3: remove unnecessary configuration recapture while resetting Date: Tue, 18 Dec 2018 19:37:52 +0800 Message-ID: <1545133079-79605-6-git-send-email-lipeng321@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545133079-79605-1-git-send-email-lipeng321@huawei.com> References: <1545133079-79605-1-git-send-email-lipeng321@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.71.200.31] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huazhong Tan When doing reset, it is unnecessary to get the hardware's default configuration again, otherwise, the user's configuration will be overwritten. Fixes: 4ed340ab8f49 ("net: hns3: Add reset process in hclge_main") Signed-off-by: Huazhong Tan Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index a8a2ccf..b66eee9 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -7380,19 +7380,6 @@ static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev) return ret; } - ret = hclge_get_cap(hdev); - if (ret) { - dev_err(&pdev->dev, "get hw capability error, ret = %d.\n", - ret); - return ret; - } - - ret = hclge_configure(hdev); - if (ret) { - dev_err(&pdev->dev, "Configure dev error, ret = %d.\n", ret); - return ret; - } - ret = hclge_map_tqp(hdev); if (ret) { dev_err(&pdev->dev, "Map tqp error, ret = %d.\n", ret); -- 1.9.1