Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Dec 2018 15:07:14 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()
Message-ID: <20181218140714.GC24278@latitude>
References: <cover.1543517818.git.christophe.leroy@c-s.fr>
 <8835330baa77d88e0267b0b1215b78c991e6d17a.1543517818.git.christophe.leroy@c-s.fr>
 <20181203215558.GK15324@latitude>
 <84624899-bbda-9f08-2527-151fddbd1b01@c-s.fr>
 <a253e9f8-1e0a-1596-e0ea-54261ac62212@c-s.fr>
 <20181217012837.GT15324@latitude>
 <18ba3a7c-ebfa-66aa-e231-b56985d0e89a@c-s.fr>
 <20181218030538.GA24278@latitude>
 <9a39d910-2a05-3ce7-c949-296db2d458b9@c-s.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="f+W+jCU1fRNres8c"
Content-Disposition: inline
In-Reply-To: <9a39d910-2a05-3ce7-c949-296db2d458b9@c-s.fr>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--f+W+jCU1fRNres8c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 18, 2018 at 09:18:42AM +0000, Christophe Leroy wrote:
> The only difference I see then are the flags. Everything else is seems
> identical.
>=20
> I know you tried already, but would you mind trying once more with the
> following change ?
>=20
[...]
> -		setbat(idx, PAGE_OFFSET + base, base, size, PAGE_KERNEL_TEXT);
> +		setbat(idx, PAGE_OFFSET + base, base, size, PAGE_KERNEL_X);

Good call, with this workaround on top of patches 1-3, it boots again:

	# mount -t debugfs d /sys/kernel/debug
	# cat /sys/kernel/debug/powerpc/block_address_translation
	---[ Instruction Block Address Translation ]---
	0: 0xc0000000-0xc0ffffff 0x00000000 Kernel EXEC
	1:         -
	2: 0xc1000000-0xc17fffff 0x01000000 Kernel EXEC
	3:         -
	4: 0xd0000000-0xd1ffffff 0x10000000 Kernel EXEC
	5:         -
	6:         -
	7:         -

	---[ Data Block Address Translation ]---
	0: 0xc0000000-0xc0ffffff 0x00000000 Kernel RW
	1: 0xfffe0000-0xffffffff 0x0d000000 Kernel RW no cache guarded
	2: 0xc1000000-0xc17fffff 0x01000000 Kernel RW
	3:         -
	4: 0xd0000000-0xd1ffffff 0x10000000 Kernel RW
	5:         -
	6:         -
	7:         -

> I think we may have some code trying to modify the kernel text without us=
ing
> code patching functions.

Is there any faster way than to sprinkle some printks in setup_kernel
and try to find the guilty piece of code this way?


Jonathan

--f+W+jCU1fRNres8c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAlwY/wkACgkQCDBEmo7z
X9tphw//eo4AefucR1Ifx7yXkmmJgCQhqeLD63BU/DIL9I5rw4tNFdmGvEh1AJ3y
vdGdGaTkya/mBGvyoDJ37eh3ldt+7N9qk7W16BZc2tjYQQRJOPht1Y/ecFypqcKc
8obxsorOVT6iAE8VoDU3ZJYZe6BZuVJCwEoPFySRl1bUYaADGIoeop5TF9ypgkrJ
LhQDUDO2SA1nQKMJ5HFfqeO8oqyo4MYt0rJqUZRP4FCIt/3caB4hcPDFv7eRdT2F
KSmmcLMPyYPDnC48vWkA5w8OKRbndPe3HRdtrWdwIbmVxBS+6mq+HDFu2qk7OhAV
KZKMieNtfgg/zOuKCX+/D+NtuLOj569vxuZShdDblcnnP8etLboF7oqtFyrmBK4+
WdoHIFLxBGiYS8QTYvPHSAkIx3e7rajrLhB+ggNXhIT7WQ71jX6KNCOYmwEJoke2
0O3s6iuMMIFDG3Jm89kovuf5B/6n10yvrr/1d+f5tLJueamBdkMG8LOPsdcXQacE
W60tfnzPqqD9jMUvWEmlSQgruc9sVlUz3pt9qNzbp8Q2PVUmfimpkrFh+ZkfWI5Y
QxW5QyQW2sUwOBCtfTLBm8wi94Ho/YR8MclmLA8hx1/2onxu70hxD9fHKzi3vD1e
ooehzWa+V46ZBr3l4pwhEJUDU2WCkxlZZTGKgspmv82r/2nQiXw=
=2uIf
-----END PGP SIGNATURE-----

--f+W+jCU1fRNres8c--