Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Dec 2018 16:26:01 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Dou Liyang <douliyangs@gmail.com>
cc:     linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        kashyap.desai@broadcom.com,
        shivasharan.srikanteshwara@broadcom.com, sumit.saxena@broadcom.com,
        ming.lei@redhat.com, hch@lst.de, bhelgaas@google.com,
        douliyang1@huawei.com
Subject: Re: [PATCH 2/3] irq/affinity: Add is_managed into struct
 irq_affinity_desc
In-Reply-To: <20181204155122.6327-3-douliyangs@gmail.com>
Message-ID: <alpine.DEB.2.21.1812181545340.14031@nanos.tec.linutronix.de>
References: <20181204155122.6327-1-douliyangs@gmail.com> <20181204155122.6327-3-douliyangs@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 4 Dec 2018, Dou Liyang wrote:
> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> index 1562a36e7c0f..d122575ba1b4 100644
> --- a/kernel/irq/affinity.c
> +++ b/kernel/irq/affinity.c
> @@ -289,6 +289,13 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)
>  	for (; curvec < nvecs; curvec++)
>  		cpumask_copy(&masks[curvec].mask, irq_default_affinity);
>  
> +	/*  Setup complementary information */
> +	for (i = 0; i < nvecs; i++) {
> +		if (i >= affd->pre_vectors && i < nvecs - affd->post_vectors)
> +			masks[i].is_managed = 1;
> +		else
> +			masks[i].is_managed = 0;

Why want you clear the bit? The masks are allocated with kcalloc() so it's
clear already.

+	/* Mark the managed interrupts */
+	for (i = affd->pre_vectors; i < nvecs - affd->post_vectors; i++)
+		masks[i].is_managed = 1;
+

Is what I made it instead.

Thanks,

	tglx