Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Dec 2018 17:34:51 +0100
From:   Oscar Salvador <osalvador@suse.de>
To:     Michal Hocko <mhocko@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Pavel Tatashin <pasha.tatashin@soleen.com>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] memory_hotplug: add missing newlines to debugging output
Message-ID: <20181218163446.ua6svkohowov35to@d104.suse.de>
References: <20181218162307.10518-1-mhocko@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181218162307.10518-1-mhocko@kernel.org>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>

> Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

> ---
>  drivers/base/memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 0e5985682642..b5ff45ab7967 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
>  			return false;
>  
>  		if (!present_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) not present",
> +			pr_warn("section %ld pfn[%lx, %lx) not present\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		} else if (!valid_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
> +			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		} else if (online_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) is already online",
> +			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		}
> -- 
> 2.19.2
> 

-- 
Oscar Salvador
SUSE L3