Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Dec 2018 11:55:42 -0500
From:   Sasha Levin <sashal@kernel.org>
To:     Dexuan Cui <decui@microsoft.com>
Cc:     "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Sasha Levin <Alexander.Levin@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
        Michael Kelley <mikelley@microsoft.com>,
        "'apw@canonical.com'" <apw@canonical.com>,
        "'olaf@aepfle.de'" <olaf@aepfle.de>,
        "'devel@linuxdriverproject.org'" <devel@linuxdriverproject.org>,
        vkuznets <vkuznets@redhat.com>,
        "'jasowang@redhat.com'" <jasowang@redhat.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Check for ring when getting debug
 info
Message-ID: <20181218165542.GA2746@sasha-vm>
References: <PU1P153MB016995B94393BB024F6DE7F8BFBC0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <PU1P153MB016995B94393BB024F6DE7F8BFBC0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 17, 2018 at 08:16:09PM +0000, Dexuan Cui wrote:
>
>fc96df16a1ce is good and can already fix the "return stack garbage" issue,
>but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
>return stack garbage, if people forget to check channel->state or
>ring_info->ring_buffer, when using the function in the future.
>
>Having an error check in the function would eliminate the potential risk.
>
>Add a Fixes tag to indicate the patch depdendency.
>
>Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels")
>Cc: stable@vger.kernel.org
>Cc: K. Y. Srinivasan <kys@microsoft.com>
>Cc: Haiyang Zhang <haiyangz@microsoft.com>
>Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>Signed-off-by: Dexuan Cui <decui@microsoft.com>
>---
>
>*NOTE*: the patch is based on char-misc's char-misc-linus branch.

Queued up, thank you.

--
Thanks,
Sasha