Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4473148imu; Tue, 18 Dec 2018 15:51:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wc1b/XlH/094mT8Oaf1ZHD9C/B9w2S5eqHJbUTaKKTZ/ulhqMVDhmU3ZnYKW4UnrljRIxr X-Received: by 2002:a63:111c:: with SMTP id g28mr17389890pgl.85.1545177093013; Tue, 18 Dec 2018 15:51:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545177092; cv=none; d=google.com; s=arc-20160816; b=wZelQslqAZ1kzmeTjIsJsEKn57ZK5kTkw6Wwd1zs/iS6dtUaLPoPOrA+4OZ0LDSVUI Q0nqSdIGsuZDceltRApBrEl2Oi1aTci2Sp78p8oxLIHZl82QO61jiBL9oqm1c/znJh/C 0fjVIku3fwBejZRM8wlkGe9cXsjZlSgFtK9JO+Psias82XvEzBILH3dkVqxZY3TZ4t2J RAYTzi+Uji7MaMuCR8l4FUeqaOovutMcoIavAb5zY8CNinI1tvGJGb9n7oF8lkP97VBa UBXpx4H9n5KQKisq/HpvX84zyrcmCNlyf3vY/DjFbW1TZ1CH7CXTi/bhIj+OVBdtuozo 7PPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=a98xkUgCTJJUb/MPoY/uX76POteUpUodigrYTdrNKwg=; b=KTE6fiK+E5EH1AVMwQ0oxrKdjzqDB/Gl1CWUTXCFvSX6AgUt/nQVEPq/22FNHuHQtj KY1vjF4YlkDlISR9UvA8CLZcFZ8xcZoo7ulPRypoABYQvJmSskUcO+lW/9on/N1UNuKW 6IMrp7iYl63FFx4T6EIbALjrocL6FNWaFw8UM2cn4+/gl1NM0pXws/emnKPjfXcS58DP 6xO7+xABdVeqmZQM64w7g04QdInzbtm10mN7pWLANbKJqav/pHU0/NVthJzdEhlt43Zv u08gFpM2feYShemnNBXHQ9g/hqKZHS80LbTzCzC35CfHbF1Xz1dFnfP8dOCSksoL04HD ZaSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si13940058plt.295.2018.12.18.15.51.17; Tue, 18 Dec 2018 15:51:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbeLRXd5 (ORCPT + 99 others); Tue, 18 Dec 2018 18:33:57 -0500 Received: from sauhun.de ([88.99.104.3]:50012 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbeLRXd5 (ORCPT ); Tue, 18 Dec 2018 18:33:57 -0500 Received: from localhost (p54B3362C.dip0.t-ipconnect.de [84.179.54.44]) by pokefinder.org (Postfix) with ESMTPSA id 240122E3542; Wed, 19 Dec 2018 00:33:55 +0100 (CET) Date: Wed, 19 Dec 2018 00:33:54 +0100 From: Wolfram Sang To: Peter Rosin Cc: Wolfram Sang , "linux-i2c@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Hans de Goede , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters Message-ID: <20181218233354.pie5i3lvrrhq5q2c@ninjato> References: <20181210210310.12677-1-wsa+renesas@sang-engineering.com> <20181210210310.12677-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kkoegvsoxj4nbwmq" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kkoegvsoxj4nbwmq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > + unsigned int is_suspended:1; /* owned by the I2C core */ >=20 > When more stuff is added to this bit field (which always happens at > some point) updates to all members of the bit field will have to use > the same root-adapter-locking, or we will suffer from RMW-races. So > this feels like an invitation for future disaster. Maybe a comment > about that to remind our future selves? Or perhaps the bit field > should be avoided altogether? Changed to bool. Thanks! --kkoegvsoxj4nbwmq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlwZg+EACgkQFA3kzBSg KbZljQ/9FWhnSg2KAf/UssubqDJ1lmNWr9tNZYeZy56inKDT504CHLS7psgOekeS ktdvqMny8x08MmKEeeKRUiAyc/G7RH2fqzYDehX7/fTp9JurpkAzUU3R3ojKKTUk LttUvwiH3sox6DTtxNwVX5L+QlrJYj7MdGYLh4C7wC5GEmaqdK0Gev5wyksiqu8b CpY5l6Mux+3ZIm1s3gQaa1mC6wVGvodvtpJ569ttR2XaaX4uhlg9OGDAGTT5Xck8 4rUiXKYBIvv3pGoq8KSNVunayb8zo82vsspr3QzCW010Tn9HKAbAJkvj85qBVcrq f7ibMz8yI0cSyewn9rxQJlO7XPrkigRTyNScUhansbHOygY0lRa2VT7yh1at3uCg FeGV6K3DSOYh43W+iy+qL+pUmiVzuTBiQ+Si+Ko3FcoGqx2OMg9dUk7Jm3ReWo5E gRF0i1i5EmpP6qtzpd4miyVlrMupj4VL5huRV1vT67UgHHyrirMnXwuvLm7Lejwb NTPAJSVCDC7lgiqnw9zfVqART0ZLm0iWGQGYOoMAVl1XCowvkB4GmSAztviWOyui m+1pEjjwNMKntfoQqSi00B4dPBwxNsYTesAoBSNJuDYwkoDcsigM42sqKykKydDa rcb4ZgX+UA8hP7VGZFnjouQWkU6KsoJNr9SxJuvqGlaOjwNvC1k= =fCGw -----END PGP SIGNATURE----- --kkoegvsoxj4nbwmq--