Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] bluetooth: Remove unnecessary smp_mb__after_atomic()
 barriers
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20181127112225.6177-1-andrea.parri@amarulasolutions.com>
Date:   Wed, 19 Dec 2018 00:49:53 +0100
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <E1EF7686-BED9-4E96-988E-8B22B2646D78@holtmann.org>
References: <20181127112225.6177-1-andrea.parri@amarulasolutions.com>
To:     Andrea Parri <andrea.parri@amarulasolutions.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andrea,

> The barriers are redundant because atomic_test_and_clear_bit() already
> provides the required full ordering for the cases in question (that is,
> when the bit is cleared).
> 
> Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> ---
> drivers/bluetooth/btusb.c     |  8 ++------
> drivers/bluetooth/hci_intel.c | 16 ++++------------
> 2 files changed, 6 insertions(+), 18 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel