Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4474557imu; Tue, 18 Dec 2018 15:53:47 -0800 (PST) X-Google-Smtp-Source: AFSGD/VXX04OCHsdgGCKXTDBWbfamkVRL/Izn1p4XiR1OMWnXbsj2o6pRuDOKW+skQ7niMlhQUF5 X-Received: by 2002:a63:e655:: with SMTP id p21mr17272527pgj.70.1545177227436; Tue, 18 Dec 2018 15:53:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545177227; cv=none; d=google.com; s=arc-20160816; b=ffj3NQy8ziwMuNtVqGEUhjRQhWPoRiIgOvOWXGH5UbjrwQnowKGOS6yEGWCDYo5Tep LIe49VWeTxqW9CiVaNaZN2v9lLh/yjo8OsCM4MH+7P/mUh2kqryCjhF1BKeagZckWYWV Ywd372jYcRtKYdntR+4za5vqXirttcdkfsUkHUn1b0qK03SW7ENhZ4iljIjeD43i5z1L aU03zVAGowle1fsKasD5QgvCCZhlsTXGyFfx9Q0cH+AsrirPKUiGuaqgCycaGHYzKFch kfzYLU0svNegvFTWrdnJJ1dfiyCQFLPmKueF0g03BDof/LIPub/h8bTwoEED5QDX5o17 z3pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=V3TRrdFUyTmjSAjk/PG07xWOKfxfinS2P8q6Icb7/O8=; b=o/i/VfpxRtWy7Igq/HPSuU5JC+zwBzvvefVmNbo03eJbIyCCiToM4clP7MTAHpcNEE LBSxN3AtKi2b/P/HWnYAwYEt3yburlMqOXcKIao7Bmynjh7ZCkTQce4dHQkaBHLjL3hk rl+c4nR1OSi8kt7U4gMAa1OF7CUI6B6CjE6T0Fp27lk1z4Q7I+8//gTjkg52Rc52TBMO MNt4XK74mOcnLGX9vzH16cna92OG6DHS3QxGDk49yhmatL/jZf+b5IA4uOTsc4EKUGI3 hPc3oV5GnBJbnq/w/Wo4eN3NroPDcTlEOnn97bmZsvU73xpKy3YZGarna3J4mC0DiasX Wfbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si14029277plp.132.2018.12.18.15.53.32; Tue, 18 Dec 2018 15:53:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728189AbeLRXun (ORCPT + 99 others); Tue, 18 Dec 2018 18:50:43 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727601AbeLRXum (ORCPT ); Tue, 18 Dec 2018 18:50:42 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 398B714878782; Tue, 18 Dec 2018 15:50:42 -0800 (PST) Date: Tue, 18 Dec 2018 15:50:41 -0800 (PST) Message-Id: <20181218.155041.273935089211418130.davem@davemloft.net> To: yuehaibing@huawei.com Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next] net: bridge: remove unneeded variable 'err' From: David Miller In-Reply-To: <20181217094623.32668-1-yuehaibing@huawei.com> References: <20181217094623.32668-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Dec 2018 15:50:42 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Mon, 17 Dec 2018 17:46:23 +0800 > function br_multicast_toggle now always return 0, > so the variable 'err' is unneeded. > Also cleanup dead branch in br_changelink. > > Signed-off-by: YueHaibing Applied.