Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4719449imu; Tue, 18 Dec 2018 22:06:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/UqA8UJM2nDqTMMAf/0aqUiiM/PyScwpZbftW4uTLXOln9NeEN9qhq++yhg1DHobGVUkJkl X-Received: by 2002:a62:9111:: with SMTP id l17mr19323036pfe.200.1545199594760; Tue, 18 Dec 2018 22:06:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545199594; cv=none; d=google.com; s=arc-20160816; b=RYxa02fT2cPoinMZ/u6gtC9dEb1hj4Tz3h8+QNSqI70tCvLvNlNNBxMsT5DW95zS2w k8kGYTR2yiT+Rt81cTtDEj4Oz4OgzOoqHgX7JtuJI9kxBb9M96N5NDMfz2npMD9ZPhv/ Lyyo+qZR4fcyQcLCiE38sWCnQxBn0J2iu/BijqerIuPURu3NLS8+F5VnJlDngQ6ib2OA oPWMLIccwza+CoX5qGWP9JRg0IUWAo34M5J6XN9e/3CW/EFuKG+HrF+aeTVIC633siMF oh306UFcZagVvq/kxn1mwO4q0asL8PPiqSz1+6pvql+uK0zoEtQ+Iq41Lc+zJBdDPlym +Uzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Fn5wrXOAY93JTMoj+dEu83URrzyd7yqD6lxveUjyf6k=; b=TexlHgCpsWp95Y/Cw71c6W2xfIM5+do1kkdA24ms91ZiRBoB5tADZVMHXqEmL6Aoh1 JdgisgU4sJMUaA8jJwa4OGru2sgJLcTVrJmyQItQ+CLGfX8zuIb3SVmrmhxL46NqtkX3 FbXdDEklpsWG6KI8jMy0pSfFwbqfN9OnDWr5Pbe8Si5AD1x3E0IuHhglkkkcwN9y2w9h EQPvD3v89zBOoBgEmDCh4aIeQjZuyAvuYDQ0t8aAIFuOWmRwhScDRyE+8SEsJBkYAWdj zhFHGNX8VDEgSQ5hRYq0aCq8frGmiW0UaQOvuvVeEH6I+0cYI5yFU4WvRTkFIAdimc/u +4zQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n13si15184720pgp.307.2018.12.18.22.06.19; Tue, 18 Dec 2018 22:06:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbeLSGD6 (ORCPT + 99 others); Wed, 19 Dec 2018 01:03:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49676 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbeLSGDz (ORCPT ); Wed, 19 Dec 2018 01:03:55 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 67935146F2BCA; Tue, 18 Dec 2018 22:03:55 -0800 (PST) Date: Tue, 18 Dec 2018 22:03:54 -0800 (PST) Message-Id: <20181218.220354.1029594559259847304.davem@davemloft.net> To: mhjungk@gmail.com Cc: ubraun@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net/smc: fix TCP fallback socket release From: David Miller In-Reply-To: <20181218170221.GA21835@myunghoj-Precision-5530> References: <20181218170221.GA21835@myunghoj-Precision-5530> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Dec 2018 22:03:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Myungho Jung Date: Tue, 18 Dec 2018 09:02:25 -0800 > clcsock can be released while kernel_accept() references it in TCP > listen worker. Also, clcsock needs to wake up before released if TCP > fallback is used and the clcsock is blocked by accept. Add a lock to > safely release clcsock and call kernel_sock_shutdown() to wake up > clcsock from accept in smc_release(). > > Reported-by: syzbot+0bf2e01269f1274b4b03@syzkaller.appspotmail.com > Reported-by: syzbot+e3132895630f957306bc@syzkaller.appspotmail.com > Signed-off-by: Myungho Jung Applied, thanks.