Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4819698imu; Wed, 19 Dec 2018 00:27:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xp0IapXiSt76Gg2MMgAZ/sOXFUTvS0RtwsYE4Sa4CRUIpUkMtXQGM7wrV9ni6L9XRqYr9t X-Received: by 2002:a62:cd44:: with SMTP id o65mr19551490pfg.222.1545208035185; Wed, 19 Dec 2018 00:27:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545208035; cv=none; d=google.com; s=arc-20160816; b=JjDg0JKOqDLqPHhT1w0TqOF3FkfRYHoS6OLgNXOnvXeJAK2W4WYFjOQumbdUhKhhFn hzxlfHsDmRvEl/ln6M5djTSDIv3A6GnWvdxv3kEVCFEamTCCmaQ78DtTHMW/dVtD8MOm NjhON3DO4hlbYzYna3kcPsyq/S7c9GuDdtjvFfQXM1q3p2ZwgxiKa4rgNVtKjBuMqQnX 7zkUgIo9Ubxrr5MwFlzRIPVRIlXMrfX66Vu2eWHqymkpCIp6RQohgn1yP+Cwzw7gjDpq HsN16STtpsc/7h0scfI//Pa4GYpSm3HpfJc0Quah3KHpqdVE/BMF9aww1JKPRsW+rKQS k89g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GbFsH92F8LYgPzCETeldoQ5SjmPUN4loEk5ARz1d5Lo=; b=h/D9o/NbzFeo9TXYLyU5fwukr5JunprLFD/umFDrcH2pEni/LxRRoSV0DCKlrWH7Tq JOpJmV/o3v3fJ/DusY6MC55J3FrTwWcut5z9v/hcNP0VbVYitjNT8Jrc6vjxUj8HqkUZ SMNyJRdDxWy+IPCCtG5ObH9yyDhHYp8AURx/UU08w1znZxNO3E1+Z4dQku5Lkk3Y5r0m imJLZSrN3cT5toPn0YUB6/1v5Hgf24sbJxU3jIYjph//Fy16Fiy0W3NRo5xDxf+JeYZU DFSSCb61k3lA7opaxRlhk9Z843oWM7Ch+zRrbVGRdlEa8WG92QYyB0DbLQh6vQhb9Lqk 9cyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FKUYdz2A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si15056762pgu.435.2018.12.19.00.26.57; Wed, 19 Dec 2018 00:27:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FKUYdz2A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbeLSHLx (ORCPT + 99 others); Wed, 19 Dec 2018 02:11:53 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:35420 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbeLSHLv (ORCPT ); Wed, 19 Dec 2018 02:11:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GbFsH92F8LYgPzCETeldoQ5SjmPUN4loEk5ARz1d5Lo=; b=FKUYdz2A7lD/wcAmN4VQB7ReZ Lgl8H/8o3qxyTy4Qrd0kzjFNfZgwEW/4A17spUy06+j1ZmKiCMGm/JqEVzULLFNVD6YgyV6A/T/wC fwJ14RzGklfd0d/VUx0k4aci1UnU9BMsLzEb6kvjWEKQqQ1Zf5xIb+E7pMp0xx6hs54HEmL8DbQHE 1KnXMPVGy4uoDSAMMFLpNVzxA6VH3qL69thOxAepoM9kB++VCMw9vauMuCiVtxdbYi/upISDr6vgt 2210gFBDEKBLzEst+J+w5wsWB+JVGqQlzfrwuOxPJT03+uI6708Oj4/J3MYcFl400o/mCRvvjJHF0 SyntpkbtA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZW1F-0002i2-MI; Wed, 19 Dec 2018 07:11:49 +0000 Date: Tue, 18 Dec 2018 23:11:49 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Eric Biggers , Christoph Hellwig , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, "Theodore Y . Ts'o" , Jaegeuk Kim , Victor Hsieh , Chandan Rajendra , Linus Torvalds Subject: Re: [PATCH v2 01/12] fs-verity: add a documentation file Message-ID: <20181219071149.GB2628@infradead.org> References: <20181101225230.88058-1-ebiggers@kernel.org> <20181101225230.88058-2-ebiggers@kernel.org> <20181212091406.GA31723@infradead.org> <20181212202609.GA193967@gmail.com> <20181213202249.GA3797@infradead.org> <20181214044802.GA681@sol.localdomain> <20181217200039.GD8111@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181217200039.GD8111@magnolia> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 12:00:39PM -0800, Darrick J. Wong wrote: > FWIW, if I were (hypothetically) working on an xfs implementation, I > likely would have settled on passing a reference to a merkle tree > through a (fd, length) pair, because that allows us plenty of options > on the back end: > > b) we could remap the tree into a new inode fork for merkle trees, or > a) remap it as posteof blocks like ext4/f2fs does, or > c) remap the blocks into the attribute fork as an (unusually large) > extended attribute value. > > If the merkle_fd isn't on the same filesystem as the fd we could at > least use generic_copy_file_range (i.e. page cache copying) to land the > merkle tree wherever we want. I think the fd would have to be on the same fs for this interface to make sense. But it could be an O_TMPFILE one. And given that ext4 already supports a variant of swapext this interface should also work with the existing ext4 on disk format.