Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4869014imu; Wed, 19 Dec 2018 01:31:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/VY+92Ouz66Oo8NOjQBE9w+3inozUDISGcSQnu4+KUl5OpsCVjjo7igoFhn4yHz+eKjw6Hd X-Received: by 2002:a17:902:690c:: with SMTP id j12mr19489011plk.206.1545211892579; Wed, 19 Dec 2018 01:31:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545211892; cv=none; d=google.com; s=arc-20160816; b=m2kjKQvRKeke8n9QJwCtAiVpfKn+1etgaXipefDp3AZAIYU5bLtAE+Mxoux0tG8zRn q5iYwXBj9IB1Eg2bXvQ+4Yx2P67TmYhwIdil/K0JbcFawnleLErCTb9UfPTvbBuWSJE4 hUbOcWcvhQHPmPtAXhbKcMRTqiBvS/QDTWn0hQmQYN6XxBsEhry6T+QJPWkC+xrtrFez dYv0ifpqgzs9FykiZqJ7BwcpgZTNPzqeSPn/I6GvIWynCgdQWlMJOt7kK2hP03FrC9Cp bkntA2RfvUr2NnEZ465NmQ0TJd1tynhsvka9g/6HriPnciuE2I48811yCXjj6MVHdudQ Rrbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/czyaOrTX0wII+l2ZWdzzoDOwrkDkVLvFMwyExEVUr0=; b=J5OpLp5rBXLg92FBl4gcU23ifDazq0aL4nTAtqHNtBKRpUefs98+EjVEc9ESh6kbZo piqDB7gbV2rWeQliIchQACbIFqcBZ7dnTz1WhYcxGlTyow0m56SJ7swzkKmhDOU2Z6et sZ0Bo3+YnG0GG2jpuGDkhsUQwweZJ/3GspTpBjt0fpboyltFHewZ5YRA+9Tmx546oK7L GL2C4GMciPaT6H9E46iF34byKIQDDtXx1KEV8fveCeqh7Z9mmxZGEOjoZNRyGQEHwwW2 VJrW7sTLJS61oSUy3C9ucFl5ihZFMHwRqP5YloWVyw4cowOIy3s9aujaQkxzE5Kyt3JD RWuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si15790985pfd.154.2018.12.19.01.31.17; Wed, 19 Dec 2018 01:31:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbeLSJPP (ORCPT + 99 others); Wed, 19 Dec 2018 04:15:15 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:53472 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727159AbeLSJPO (ORCPT ); Wed, 19 Dec 2018 04:15:14 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJ99cW7008693; Wed, 19 Dec 2018 03:15:12 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail1.cirrus.com (mail1.cirrus.com [141.131.3.20]) by mx0b-001ae601.pphosted.com with ESMTP id 2pcxwr78cj-1; Wed, 19 Dec 2018 03:15:11 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail1.cirrus.com (Postfix) with ESMTP id 6A1BE611C8BC; Wed, 19 Dec 2018 03:15:11 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 19 Dec 2018 09:15:10 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wBJ9FAPr012034; Wed, 19 Dec 2018 09:15:10 GMT Date: Wed, 19 Dec 2018 09:15:10 +0000 From: Charles Keepax To: Paul Gortmaker CC: Lee Jones , , Linus Walleij , Subject: Re: [PATCH 17/18] mfd: wm8350-core: drop unused module infrastructure from non-modular code Message-ID: <20181219091510.GZ16508@imbe.wolfsonmicro.main> References: <1545078688-21217-1-git-send-email-paul.gortmaker@windriver.com> <1545078688-21217-18-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1545078688-21217-18-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=905 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812190080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 03:31:27PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM8350 > drivers/mfd/Kconfig: bool > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > We delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We replace module.h with init.h and export.h ; the latter since the > file does export some symbols. > > Previous demodularizaion work has made wm8350_device_exit() no longer > used, so it is also removed from the 8350 core code. > > Cc: Linus Walleij > Cc: Charles Keepax > Cc: Lee Jones > Cc: patches@opensource.cirrus.com > Signed-off-by: Paul Gortmaker > --- Acked-by: Charles Keepax Thanks, Charles