Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4869389imu; Wed, 19 Dec 2018 01:32:00 -0800 (PST) X-Google-Smtp-Source: AFSGD/UEPDIyVTgFUZWKwGCRAq1fLtyGb3cAbFvxCU2J760Mm8FBHI9qefFOL4xtshFmfKOzW6pn X-Received: by 2002:a17:902:9f93:: with SMTP id g19mr19279167plq.195.1545211919987; Wed, 19 Dec 2018 01:31:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545211919; cv=none; d=google.com; s=arc-20160816; b=TAuVDEYpap5fu294DOhV/Vs6lzKZxKcvMiS9oH1iKKLnoqijj6a/sP1e6u8F9KX+gM 8YYcT4OUmVSRfdWrKWReVrgbxcf+du0IbVbWvuoQzyg6ezlR0D7wUhlnBf2xdGwYQimz qrzYr8gmXp2HK5jGGG5sd5amkEZhihiuHA+ICO3Ayw+OPm6EY/36ixATx04Dq8z3dVfZ PZ06OTletCw056msgp5iKYkUki2FzR4ftK1EzUrsAvb97ls4U+0lT9JUCIn45vBuEBxW 6i/3LKQ6PUdMI19bH0U5wr20YhEovwBzW8wyKqbCBwkn3KlQlwY6Wv3OVpOB6KISsxY4 pCjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NbcxNHsKxwWx4F0GD68thj2qT+Hn67y4v39RxP1zvd8=; b=NwXGVetURj2OtbH05CqezQjhw4hysrgDOIk8tCDX7f5vnv02avS7VU0y20jAjSG1G6 OPpfcWSufCUp3JroHlmtZQCc4jWEIk2dvB9ptlWxjRXRucyQEhaEPxE77KMqZtJAYdTg LQ9/gAupY4m3vUJjdLru6fvjQricQPiyW/aBUcRuRE6EojNmCFrVxznQR79VRSbmgv6T EQieufO9gf0oosly8gYRvWi9boHAZO2lwcGfmAMlgXeQL+ex9pG0Tiv9hpQXuZ4j2dXi 0GI/ruJa8/uKZTD/vZgav9dEM+NouAVe5MY8WF+ErVWPxRNC5Z5JOA2JyiXBcAzjGnKj GtAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si15734516pgk.169.2018.12.19.01.31.44; Wed, 19 Dec 2018 01:31:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728627AbeLSJOH (ORCPT + 99 others); Wed, 19 Dec 2018 04:14:07 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:37804 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726818AbeLSJOG (ORCPT ); Wed, 19 Dec 2018 04:14:06 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJ99Psu025566; Wed, 19 Dec 2018 03:14:05 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0a-001ae601.pphosted.com with ESMTP id 2pcyw5qj4n-1; Wed, 19 Dec 2018 03:14:04 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id 5711F611B6D0; Wed, 19 Dec 2018 03:17:54 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 19 Dec 2018 09:14:04 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wBJ9E2C5011923; Wed, 19 Dec 2018 09:14:03 GMT Date: Wed, 19 Dec 2018 09:14:02 +0000 From: Charles Keepax To: Paul Gortmaker CC: Lee Jones , , Subject: Re: [PATCH 13/18] mfd: wm831x-spi: Make it explicitly non-modular Message-ID: <20181219091402.GV16508@imbe.wolfsonmicro.main> References: <1545078688-21217-1-git-send-email-paul.gortmaker@windriver.com> <1545078688-21217-14-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1545078688-21217-14-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=924 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812190080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 03:31:23PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM831X_SPI > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with SPI" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Lee Jones > Cc: patches@opensource.cirrus.com > Signed-off-by: Paul Gortmaker > Acked-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles