Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4982016imu; Wed, 19 Dec 2018 03:42:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/WPSX/Wuxzm/+Qrq05tJFgzXkCOfMIgrEos3iyLQUxks87TYmbKVyFsWCOWl9BLLAfaSPrh X-Received: by 2002:a17:902:bb98:: with SMTP id m24mr19405931pls.71.1545219734287; Wed, 19 Dec 2018 03:42:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545219734; cv=none; d=google.com; s=arc-20160816; b=uhYw1pvU+/j4RwaducgpfSn69XcfmQ87wHaWYseYS6IgKNnVqYGmCnjqr88kxdD0tq sKRaTTQpyBTwLIt+7mB/y0pLkOL/Vml9kaO+g9AC1egRO90Heo79txcim+j4L4jQl+w3 1OdGQrqTKdhr0bkZtXrlPQkG3sk/9QWD5BxIDWssZjEJMReHKHVRglPwgOS0qaIrBpBq 9qOuWsHSVlpp3fGpaisr0BbhCTmMKlHRbailXuDTK2QzIz5vyIKgwiwmZZknU6UamBsR anG8243bVgFONKilbSAJJWBBDZt19mHPZ0zPH5L5Gc4zaYSVhjhU89rg52vKIc6D9anz m6hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WpCOEUnU9SAoq7xR0YJGHj71b5MQlLjmOc2voJYwHFA=; b=NOBAmVpNhsXECxBVKNRGeIs5/lz41CM4iGeHr4Rb0BJuUcw6ovflf4HG7tszbh/99w FiQq0pKavbwAc2TQ7HSDsdVe0OqZwuruh1635q+9sUBUU4Tz65kO5s8cCexUfsA79Q3g 8nGIvIr17kRY886h2PykUy5fni4i+RLG2Ud1FBfGGJBwTuatZfdbW0C50R4Qf0DWymlk Kpxu0FC/hdhIuDwELCOwQwXLaxXEOVt42zORqNeU/gyBr37pziXnow2txgtJjuGAvo41 dqPa2ytu++InD7qSdo8XDlQC5TI0MpMg7vxhb9sriPaMoe82nq9iGRACWMBNDx1yhoFL Qlmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8si14909328pll.187.2018.12.19.03.41.56; Wed, 19 Dec 2018 03:42:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbeLSJOT (ORCPT + 99 others); Wed, 19 Dec 2018 04:14:19 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:53360 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbeLSJOT (ORCPT ); Wed, 19 Dec 2018 04:14:19 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJ99Mhx008251; Wed, 19 Dec 2018 03:14:16 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail1.cirrus.com (mail1.cirrus.com [141.131.3.20]) by mx0b-001ae601.pphosted.com with ESMTP id 2pcxwr78b3-1; Wed, 19 Dec 2018 03:14:16 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail1.cirrus.com (Postfix) with ESMTP id 68D2F611C8BA; Wed, 19 Dec 2018 03:14:16 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 19 Dec 2018 09:14:15 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wBJ9EFPv011937; Wed, 19 Dec 2018 09:14:15 GMT Date: Wed, 19 Dec 2018 09:14:15 +0000 From: Charles Keepax To: Paul Gortmaker CC: Lee Jones , , Subject: Re: [PATCH 14/18] mfd: wm831x-i2c: Make it explicitly non-modular Message-ID: <20181219091415.GW16508@imbe.wolfsonmicro.main> References: <1545078688-21217-1-git-send-email-paul.gortmaker@windriver.com> <1545078688-21217-15-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1545078688-21217-15-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=811 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812190080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 03:31:24PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM831X_I2C > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with I2C" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Lee Jones > Cc: patches@opensource.cirrus.com > Signed-off-by: Paul Gortmaker > Acked-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles