Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181207165011.31497-1-geert@linux-m68k.org> <CAMuHMdXj67QnqeMHGr_TiEaJr6gUw5qzWFvaJvoVkm89Kiuq_Q@mail.gmail.com>
 <87o99pmib8.fsf@igel.home> <87a7l4rnb3.fsf@igel.home> <875zvsrlq4.fsf@igel.home>
In-Reply-To: <875zvsrlq4.fsf@igel.home>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 19 Dec 2018 10:34:19 +0100
Message-ID: <CAMuHMdWvDohdrgDwgCBGt17Q7k1Wi=DJ2o-XSEO5vKDwH8OJnw@mail.gmail.com>
Subject: Re: [PATCH v3] m68k: Fix memblock-related crashes
To:     Andreas Schwab <schwab@linux-m68k.org>
Cc:     rppt@linux.ibm.com, Michael Schmitz <schmitzmic@gmail.com>,
        Sam Creasey <sammy@sammy.net>,
        Greg Ungerer <gerg@linux-m68k.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andreas,

On Mon, Dec 17, 2018 at 8:34 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Dez 17 2018, Andreas Schwab <schwab@linux-m68k.org> wrote:
> > On Dez 13 2018, Andreas Schwab <schwab@linux-m68k.org> wrote:
> >> I'm now getting this Oops:
> >>
> >> [   65.390000] Unable to handle kernel NULL pointer dereference at virtual address (ptrval)
> >> [   65.390000] Oops: 00000000
> >> [   65.390000] Modules linked in: nls_iso8859_1 nls_cp437 vfat fat virtio_rng virtio_blk virtio_ring virtio xfs btrfs xor zlib_deflate raid6_pq libcrc32c reiserfs squashfs fuse dm_snapshot dm_bufio dm_mod binfmt_misc loop sg
> >> [   65.390000] PC: [<00211544>] blk_throtl_bio+0x10e/0x592
> >
> > And the crash does not occur when I revert commit 1008a11590.
>
> That is not true, so this is an unrelated bug.

Thank you.

So I'll queue my patch as a late fix for v4.20.
Sun-3 can be fixed when someone can test Mike's suggestion.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds