Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5256796imu; Wed, 19 Dec 2018 08:07:50 -0800 (PST) X-Google-Smtp-Source: AFSGD/UvQakcLy4zYRiim0fjXCikYBj9a2BaiXCILnKiADJxDbbQ0Ey/+miS3v7AbNXl9IrEMEJX X-Received: by 2002:a62:33c1:: with SMTP id z184mr20857078pfz.104.1545235670135; Wed, 19 Dec 2018 08:07:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545235670; cv=none; d=google.com; s=arc-20160816; b=vLo6nIojYlsOmTsc/+XLyXcdaS6GEg80w/4K38YUxk/3ATPaEL/QzU/yFrWehz3W59 rhmbQaPsfhKE9ft3uX0UEqhQJoZY3TA6ghhZv2COooFMyiqJgHEjcnke4DlRZDbP90Dx j5eGaohmrz9e3xWixWGUHuHGyrjjbl1qqlgDHaQ3Hx1aJdaq1lmQv0ueW6126rYwysL4 An8Z21gL0WXnw3OTxb9FYV+bJcOWEIiQ03zM7+mKn+9Tx9esR+1y97yextExf+gjdqwS y/uITawx7yyIM3Kr+iqAtBV94caUo21nEDFzMp+4gk114z6lEo4rxIW5vXnHihnT43Ws mk2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=V63ejQk8zG0+daiwzStvSgR4G8u7bO2G5auIgBTDi8w=; b=ALa+K9X2zi8H4Clhvgaz7PIfKTzM5kPlT/obKQ3a1486YZ6cao+LePiGP8Bp3tIEY3 s/PLjAFSQ1+ASAHnuMEUdaMbWk+7zPGk6sNTsY/CC/yVkMGbv0unYKex3bKmZ+/iEhlb XzvqRlWS+vSXe2bEFVOWRWVhDF0aV2i356G7aH+iY7121UhkzqIWfKfQPLuCW334WEmS EerMFD38qkSLyU46aFL12Iu/yqnJaCLa65FZMZRzlsvxxEesivNrNhZhJLlnjjx31WdX Rog1C06Falnk8tChqwHxkzFMoVpxua5zauh4OcWkSdmu1EBoJ00+dJnMgoQ93mPVfPmp MEaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si15697033pgh.39.2018.12.19.08.07.01; Wed, 19 Dec 2018 08:07:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730241AbeLSPab convert rfc822-to-8bit (ORCPT + 99 others); Wed, 19 Dec 2018 10:30:31 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:58946 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728842AbeLSPab (ORCPT ); Wed, 19 Dec 2018 10:30:31 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1gZdni-0006lA-Jj; Wed, 19 Dec 2018 16:30:22 +0100 Date: Wed, 19 Dec 2018 16:30:22 +0100 From: Sebastian Andrzej Siewior To: Catalin Marinas Cc: He Zhe , tglx@linutronix.de, rostedt@goodmis.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT Message-ID: <20181219153022.w5le6nf7meiogh72@linutronix.de> References: <1542877459-144382-1-git-send-email-zhe.he@windriver.com> <20181123095314.hervxkxtqoixovro@linutronix.de> <40a63aa5-edb6-4673-b4cc-1bc10e7b3953@windriver.com> <20181130181956.eewrlaabtceekzyu@linutronix.de> <20181205191400.qrhim3m3ak5hcsuh@linutronix.de> <16ac893a-a080-18a5-e636-7b7668d978b0@windriver.com> <20181218150744.GB20197@arrakis.emea.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20181218150744.GB20197@arrakis.emea.arm.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-12-18 15:07:45 [+0000], Catalin Marinas wrote: … > It may be worth running some performance/latency tests during kmemleak > scanning (echo scan > /sys/kernel/debug/kmemleak) but at a quick look, > I don't think we'd see any difference with a raw_spin_lock_t. > > With a bit more thinking (though I'll be off until the new year), we > could probably get rid of the kmemleak_lock entirely in scan_block() and > make lookup_object() and the related rbtree code in kmemleak RCU-safe. Okay. So let me apply that patch into my RT tree with your ack (from the other email). And then I hope that it either shows up upstream or gets replaced with RCU in the ende :) Thanks. Sebastian