Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1545234725.5874.38.camel@pengutronix.de>
Subject: Re: [v4] PCI: imx: make msi work without CONFIG_PCIEPORTBUS=y
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Richard Zhu <hongxing.zhu@nxp.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Andrew Smirnov <andrew.smirnov@gmail.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Sven Van Asbroeck <thesven73@gmail.com>,
        Niklas Cassel <niklas.cassel@axis.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Trent Piepho <tpiepho@impinj.com>
Date:   Wed, 19 Dec 2018 16:52:05 +0100
In-Reply-To: <20181219141241.GB12763@google.com>
References: <1544768762-18124-1-git-send-email-hongxing.zhu@nxp.com>
         <20181219141241.GB12763@google.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Mittwoch, den 19.12.2018, 08:12 -0600 schrieb Bjorn Helgaas:
> [+cc Sven, Trent, et al from related report:
> https://lore.kernel.org/linux-pci/20181218210444.5950-1-TheSven73@googlemail.com]
> 
> On Fri, Dec 14, 2018 at 06:44:15AM +0000, Richard Zhu wrote:
> > Assertion of the MSI Enable bit of RC's MSI CAP is mandatory required to
> > trigger MSI on i.MX6 PCIe.
> > This bit would be asserted when CONFIG_PCIEPORTBUS=y.
> > Thus, the MSI works fine on i.MX6 PCIe before the commit "f3fdfc4".
> > 
> > Assert it unconditionally when MSI is enabled.
> > Otherwise, the MSI wouldn't be triggered although the EP is present and
> > the MSIs are assigned.
> 
> OK, I think I finally understand most of what's going on.  Please
> check the following possible changelog text:
> 
>   The MSI Enable bit in the MSI Capability (PCIe r4.0, sec 7.7.1.2)
>   controls whether a Function can request service using MSI.
> 
>   i.MX6 Root Ports implement the MSI Capability and may use MSI to
>   request service for events like PME, hotplug, AER, etc.  In
>   addition, on i.MX6, the MSI Enable bit controls delivery of MSI
>   interrupts from components below the Root Port.
> 
>   Prior to f3fdfc4ac3a2 ("PCI: Remove host driver Kconfig selection of
>   CONFIG_PCIEPORTBUS"), enabling CONFIG_PCI_IMX6 automatically also
>   enabled CONFIG_PCIEPORTBUS, and when portdrv claimed the Root Ports,
>   it set the MSI Enable bit so it could use PME, hotplug, AER, etc.
>   As a side effect, that also enabled delivery of MSI interrupts from
>   downstream components.
> 
>   After f3fdfc4ac3a2, the imx6q-pcie driver can operate without
>   portdrv, but that means imx6q-pcie must set the MSI Enable bit
>   itself if downstream components use MSI.
> 
>   Fixes: f3fdfc4ac3a2 ("PCI: Remove host driver Kconfig selection of CONFIG_PCIEPORTBUS")
> 
> I still don't understand exactly *how* MSI Enable affects MSI from
> downstream components, since the downstream component just does a DMA
> write, and the Root Port can't tell whether the write is to memory or
> interrupt controller unless the Root Port knows where the MSI targets
> are, e.g., if the interrupt controller is actually part of the RC.

The controller terminating the MSI write is part of the DWC PCIe host
controller on i.MX6, which is questionable at least when you think
about how a MSI should be self-synchronizing to memory writes, but
that's reality...

As to why the controller needs the MSI Enable bit set, I have no idea.
But then the DWC controller is known to have some funky design
limitations regarding MSI, like not forwarding legacy PCI interrupts
anymore when MSI is enabled, so it's not totally surprising that we
need some quirky setup here.

Regards,
Lucas