Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181218210444.5950-1-TheSven73@googlemail.com> <1545174393.22930.65.camel@impinj.com>
In-Reply-To: <1545174393.22930.65.camel@impinj.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Wed, 19 Dec 2018 09:36:07 -0500
Message-ID: <CAGngYiXRXmgWQwUGRrymZzbD-sRqHmzP2u4ysv15S1ha8vbn2g@mail.gmail.com>
Subject: Re: [RFC BUG] pci: Freescale i.MX6 PCIe controller: revert mainline regression
To:     Trent Piepho <tpiepho@impinj.com>
Cc:     "shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
        "niklas.cassel@axis.com" <niklas.cassel@axis.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "kishon@ti.com" <kishon@ti.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thank you Trent !

This patch was intended as a bug report, rather than an actual
solution to be merged.
I chose this format so people could easily verify the change in
behaviour, just by
applying the patch locally.

On Tue, Dec 18, 2018 at 6:06 PM Trent Piepho <tpiepho@impinj.com> wrote:
>
>
> It's actually commit f3fdfc4ac3a2 ("PCI: Remove host driver Kconfig
> selection of CONFIG_PCIEPORTBUS") that made this problem apparent.
>
> But the real bug is not in that commit, but a problem with imx6/7 not
> configuring a setting in the RC correctly without pcieportbus, which
> should not be necessary.
>
> See "[v4] PCI: imx: make msi work without CONFIG_PCIEPORTBUS=y" by
> Richard Zhu for a real fix.

Awesome! I can verify this patch on our i.MX6 boards, if Richard Zhu
(or anyone else) is interested.

>
> There another bug that makes this driver sometimes lose an MSI, but

Is it the one you alerted me to before?
https://patchwork.kernel.org/patch/10657987/

We are planning to use the PCIe controller in a production environment -
to communicate with a tg3 based Broadcom ethernet NIC.

What are the practical consequences of this bug?
What is the state of the patch that fixes it?
Last patch activity seems to have been in mid-November?

Apologies for the trivial questions, I am by no means a PCIe expert.

> that regression was in v4.14 and would not be fixed by your patch, so
> this tigon3 problem is almost certainly caused by the previously
> mentioned issue with pcieportbus.
>