Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <minas.harutyunyan@synopsys.com>
To:     John Keeping <john@metanate.com>,
        Minas Harutyunyan <minas.harutyunyan@synopsys.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arthur.petrosyan@synopsys.com" <arthur.petrosyan@synopsys.com>
Subject: Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling
Thread-Topic: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling
Thread-Index: AQHUatZW7CBOg1jSlEOevZqXY6bG3Q==
Date:   Wed, 19 Dec 2018 14:09:01 +0000
Message-ID: <410670D7E743164D87FA6160E7907A56013A7BECBB@am04wembxa.internal.synopsys.com>
References: <20181023134355.29829-1-john@metanate.com>
 <410670D7E743164D87FA6160E7907A56013A79E7CE@am04wembxa.internal.synopsys.com>
 <20181108173654.118f9e3e@donbot>
 <410670D7E743164D87FA6160E7907A56013A7A0F2B@am04wembxa.internal.synopsys.com>
 <410670D7E743164D87FA6160E7907A56013A7A12C1@am04wembxa.internal.synopsys.com>
 <20181109184246.33cb4487@donbot>
 <410670D7E743164D87FA6160E7907A56013A7A27D7@am04wembxa.internal.synopsys.com>
 <20181112224626.6b44568a@donbot>
 <410670D7E743164D87FA6160E7907A56013A7BAB28@am04wembxa.internal.synopsys.com>
 <20181218143504.027fc53c@donbot>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,=0A=
=0A=
On 12/18/2018 6:35 PM, John Keeping wrote:=0A=
> Hi Minas,=0A=
> =0A=
> On Fri, 14 Dec 2018 09:00:08 +0000=0A=
> Minas Harutyunyan <minas.harutyunyan@synopsys.com> wrote:=0A=
>> First of all, sorry for delayed answer.=0A=
>> Looks like similar issue seen by Andrzej Pietrasiewicz=0A=
>> <andrzej.p@samsung.com>: "dwc2 isochronous transfers issues". Same=0A=
>> feedback provided to Andrzej.=0A=
>>=0A=
>> I run tests on 4.20.0-rc4 in DDMA. By default IN ISOC traffic failed=0A=
>> because of BNA interrupts. It's happen because UAC2 requests count=0A=
>> set by default to 2. Our core and driver can't work in DDMA with=0A=
>> descriptor list length equal to 2. It's not possible on time prepare=0A=
>> next descriptors to avoid BNA interrupt.=0A=
>>=0A=
>> By changing UAC2_DEF_REQ_NUM to 4 all audio gadget tests passed=0A=
>> smoothly. Could you please apply this patch and run tests in DDMA=0A=
>> mode:=0A=
>>=0A=
>> diff --git a/drivers/usb/gadget/function/u_uac2.h=0A=
>> b/drivers/usb/gadget/function/u_uac2.h=0A=
>> index 8362ee572e1e..5e649259ab76 100644=0A=
>> --- a/drivers/usb/gadget/function/u_uac2.h=0A=
>> +++ b/drivers/usb/gadget/function/u_uac2.h=0A=
>> @@ -21,7 +21,7 @@=0A=
>>    #define UAC2_DEF_CCHMASK 0x3=0A=
>>    #define UAC2_DEF_CSRATE 64000=0A=
>>    #define UAC2_DEF_CSSIZE 2=0A=
>> -#define UAC2_DEF_REQ_NUM 2=0A=
>> +#define UAC2_DEF_REQ_NUM 4=0A=
>>=0A=
>>    struct f_uac2_opts {=0A=
>>           struct usb_function_instance    func_inst;=0A=
>>=0A=
>>=0A=
>> If it will OK on your side also then will switch to BDMA mode and=0A=
>> debug.=0A=
> =0A=
> With DDMA enabled, I see the following error after the stream has been=0A=
> running for a while (anything from a few seconds to a few minutes):=0A=
> =0A=
> -- >8 --=0A=
> [ 1798.836322] dwc2 ff580000.usb: dwc2_hsotg_ep_disable: called for ep0=
=0A=
> [ 1798.836329] dwc2 ff580000.usb: dwc2_hsotg_ep_disable: called for ep0=
=0A=
> [ 1798.851092] dwc2 ff580000.usb: new device is high-speed=0A=
> [ 1798.924461] dwc2 ff580000.usb: new device is high-speed=0A=
> [ 1798.982887] dwc2 ff580000.usb: new address 25=0A=
> [ 1799.002463] configfs-gadget gadget: high-speed config #1: config=0A=
> -- 8< --=0A=
> =0A=
> On the host side (Linux 4.18.16 Intel xHCI), I see this logged at the=0A=
> same time:=0A=
> =0A=
> -- >8 --=0A=
> [1735740.716242] retire_capture_urb: usb 1-2.2.7: frame 0 active: -71=0A=
> [1735740.716990] retire_capture_urb: usb 1-2.2.7: frame 0 active: -71=0A=
> [1735740.717906] retire_capture_urb: usb 1-2.2.7: frame 0 active: -71=0A=
> [1735740.718905] retire_capture_urb: usb 1-2.2.7: frame 0 active: -71=0A=
> [1735740.719916] retire_capture_urb: usb 1-2.2.7: frame 0 active: -71=0A=
> [1735740.720032] usb 1-2.2-port7: disabled by hub (EMI?), re-enabling...=
=0A=
> [1735740.720036] usb 1-2.2.7: USB disconnect, device number 28=0A=
> [1735740.937500] usb 1-2.2.7: new high-speed USB device number 29 using x=
hci_hcd=0A=
> -- 8< --=0A=
> =0A=
> The device does then enumerate and works for a period of time before the=
=0A=
> same error happens again.=0A=
> =0A=
 From logs not clear who initiate disconnect: host or device.  More =0A=
probably host, after some errors in retire_capture_urb initiate =0A=
disconnect. Do you have any idea?=0A=
Can't you connect device to host on same platform?=0A=
If root cause of disconnect by host is device issue, i.e. not able to =0A=
send to host data packets in time then I need device side dmesg log with =
=0A=
debug enabled. USB trace around the disconnect will help to debug.=0A=
=0A=
Thanks,=0A=
Minas=0A=
=0A=
> =0A=
> Regards,=0A=
> John=0A=
> =0A=
=0A=