Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5412185imu; Wed, 19 Dec 2018 10:38:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/UmXkI/M6GueFInkU97CXpoyFaq1mGZu9ChPacoxe1qhtVWlNj8hlt79brElmhDTMQCbnQw X-Received: by 2002:a63:bc02:: with SMTP id q2mr17179086pge.116.1545244694510; Wed, 19 Dec 2018 10:38:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545244694; cv=none; d=google.com; s=arc-20160816; b=nznf5HKLpIuzIR0+RTRFcpjq2sHddhYcKD3tz5aDL6Lg8gCdg/6TknBc/GZ5FnLjHW eIooLG5093yDJbSZO9NwibeUCeK1jfPnV0rPyxZP/mmbS5riCMH7FNcgtnasTfLrxIh/ yrXB7Xo3HxBWSTFEND6jNFbarXrJLLz0Wit17TLMtZtlT3c93V/HHbgLxxYYezwvPclo OLBMjWxfde1wreZQNr3idvqEv2uPlPKbf5sFQe82/eQqh/zBbvJbRSmSjDrIcEVu8wBv jeW23VfLB3Ic74n7uKx5LF6a46GOIzlVLJPJsM9xK/nAWkFXPEntBGyiispHoWZ/abJU kWRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ipk70XgawFq2DrKpbmaNeO7sDiuavgSWfwjNSok6DcE=; b=08DExxM5c6mTXZweLTt3s8fi3rso8ry7/D/Mu8yQCIOB6TBGDlGdVdLzZA6mkGBHa4 RTqE8IIHDCe2B32Te3BahwLuL5uaWMaIq3+9nUVJzvujQftnhovvQ6jqpVwuUxOG4w7U kjBGOGq2vwhoLEZT4wnOnkL46UR4ZWufwjLzi/0pqcC9R2RzuNK8VfkPfsX+8pHf0JPv 63FLDm3pe0l0GHK5sxSZeKB2qgaeWn58g01+VJWd3YugQqPFPXEn2VOJldwJ/STKKjvx tWDHV6c4mBNHf22k65TTB0rEJo8G//h934VtYa5Dwsr7E7ve+snWM6/ACVKFU9gX7syn 7PFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TcQZKlQv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g59si17104096plb.302.2018.12.19.10.37.58; Wed, 19 Dec 2018 10:38:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TcQZKlQv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730197AbeLSQ5x (ORCPT + 99 others); Wed, 19 Dec 2018 11:57:53 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34626 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728183AbeLSQ5x (ORCPT ); Wed, 19 Dec 2018 11:57:53 -0500 Received: by mail-wr1-f68.google.com with SMTP id j2so20277902wrw.1 for ; Wed, 19 Dec 2018 08:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ipk70XgawFq2DrKpbmaNeO7sDiuavgSWfwjNSok6DcE=; b=TcQZKlQvs15wtS/CjJG+zHvmHWgqRhWd5WtBB0rf1SA/d9trc8i9CNFsrsjzkCV08q cbuvtNAryuks1vQLynHEmEk76xrKaavnxOaIoDgn67BbsD0QKkAZqVy9G9NgQfitfhaW UobZwQ7I4D4Ea0fwx+sD+MtA3hohdf73Ol9L4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ipk70XgawFq2DrKpbmaNeO7sDiuavgSWfwjNSok6DcE=; b=SiDiGWYRE1cGmzVkL/XmwxWE1fd8F3kxGRuiQjQ4iDyONHEIFLb15zhchUDPi5oeGc IQziHTd+Vo14h7TlmVjvhX9bC1np+TiH/QNIiNra2aHNMdWNHly0SOd9eA6F3X0aPs6c GzDaGX91lsC25cnJ1NTh2L05psiV9WzA+LbhO0N5JaDwAyWWtnAQidzVhO3vajOCAQQn CvTEuLUxsquTBmYrsTaqisnjjwfN1EqRHX8MrEwWayukkWDKi/5Jcj9+cVwIokMVXDj+ YCIPpFHFMfbQXQ8nhJ93fLqjIs6wdGJswnhZPDxeDH3mf9CNELB++5IqNbrD2NYOUR+x izrw== X-Gm-Message-State: AA+aEWam4TrpOqootJnpQsP0uoRXCvOxelvbREcfzgw+wwSaUyMmu8If YwqIed/OVB11a2TMawSdb+2rdQ== X-Received: by 2002:adf:ed46:: with SMTP id u6mr20128419wro.262.1545238670653; Wed, 19 Dec 2018 08:57:50 -0800 (PST) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id z9sm5494906wrs.63.2018.12.19.08.57.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 08:57:49 -0800 (PST) Date: Wed, 19 Dec 2018 16:57:47 +0000 From: Daniel Thompson To: Christophe Leroy Cc: Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Yoshinori Sato , Richard Kuo , Michal Simek , Ralf Baechle , Paul Burton , James Hogan , Ley Foon Tan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Jason Wessel , Douglas Anderson , Randy Dunlap , "Gustavo A. R. Silva" , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net Subject: Re: [PATCH v2 2/2] kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops Message-ID: <20181219165747.ltfs65vt3tycrl7x@holly.lan> References: <030d63848e4b0ef4d76ca24597ab8302a393d692.1544083483.git.christophe.leroy@c-s.fr> <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2018 at 08:07:40PM +0000, Christophe Leroy wrote: > checkpatch.pl reports the following: > > WARNING: struct kgdb_arch should normally be const > #28: FILE: arch/mips/kernel/kgdb.c:397: > +struct kgdb_arch arch_kgdb_ops = { > > This report makes sense, as all other ops struct, this > one should also be const. This patch does the change. > > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Richard Kuo > Cc: Michal Simek > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: Ley Foon Tan > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: x86@kernel.org > Acked-by: Daniel Thompson > Acked-by: Paul Burton > Signed-off-by: Christophe Leroy I've not heard any objections from the arch/ maintainers so... Applied! Thanks. > - > --- > v2: Added CCs to all maintainers/supporters identified by get_maintainer.pl and Acks from Daniel and Paul. > > arch/arc/kernel/kgdb.c | 2 +- > arch/arm/kernel/kgdb.c | 2 +- > arch/arm64/kernel/kgdb.c | 2 +- > arch/h8300/kernel/kgdb.c | 2 +- > arch/hexagon/kernel/kgdb.c | 2 +- > arch/microblaze/kernel/kgdb.c | 2 +- > arch/mips/kernel/kgdb.c | 2 +- > arch/nios2/kernel/kgdb.c | 2 +- > arch/powerpc/kernel/kgdb.c | 2 +- > arch/sh/kernel/kgdb.c | 2 +- > arch/sparc/kernel/kgdb_32.c | 2 +- > arch/sparc/kernel/kgdb_64.c | 2 +- > arch/x86/kernel/kgdb.c | 2 +- > include/linux/kgdb.h | 2 +- > 14 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/arc/kernel/kgdb.c b/arch/arc/kernel/kgdb.c > index 9a3c34af2ae8..bfd04b442e36 100644 > --- a/arch/arc/kernel/kgdb.c > +++ b/arch/arc/kernel/kgdb.c > @@ -204,7 +204,7 @@ void kgdb_roundup_cpus(unsigned long flags) > local_irq_disable(); > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* breakpoint instruction: TRAP_S 0x3 */ > #ifdef CONFIG_CPU_BIG_ENDIAN > .gdb_bpt_instr = {0x78, 0x7e}, > diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c > index caa0dbe3dc61..21a6d5958955 100644 > --- a/arch/arm/kernel/kgdb.c > +++ b/arch/arm/kernel/kgdb.c > @@ -274,7 +274,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt) > * and we handle the normal undef case within the do_undefinstr > * handler. > */ > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > #ifndef __ARMEB__ > .gdb_bpt_instr = {0xfe, 0xde, 0xff, 0xe7} > #else /* ! __ARMEB__ */ > diff --git a/arch/arm64/kernel/kgdb.c b/arch/arm64/kernel/kgdb.c > index a20de58061a8..fe1d1f935b90 100644 > --- a/arch/arm64/kernel/kgdb.c > +++ b/arch/arm64/kernel/kgdb.c > @@ -357,7 +357,7 @@ void kgdb_arch_exit(void) > unregister_die_notifier(&kgdb_notifier); > } > > -struct kgdb_arch arch_kgdb_ops; > +const struct kgdb_arch arch_kgdb_ops; > > int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt) > { > diff --git a/arch/h8300/kernel/kgdb.c b/arch/h8300/kernel/kgdb.c > index 1a1d30cb0609..602e478afbd5 100644 > --- a/arch/h8300/kernel/kgdb.c > +++ b/arch/h8300/kernel/kgdb.c > @@ -129,7 +129,7 @@ void kgdb_arch_exit(void) > /* Nothing to do */ > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: trapa #2 */ > .gdb_bpt_instr = { 0x57, 0x20 }, > }; > diff --git a/arch/hexagon/kernel/kgdb.c b/arch/hexagon/kernel/kgdb.c > index 16c24b22d0b2..f1924d483e78 100644 > --- a/arch/hexagon/kernel/kgdb.c > +++ b/arch/hexagon/kernel/kgdb.c > @@ -83,7 +83,7 @@ struct dbg_reg_def_t dbg_reg_def[DBG_MAX_REG_NUM] = { > { "syscall_nr", GDB_SIZEOF_REG, offsetof(struct pt_regs, syscall_nr)}, > }; > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* trap0(#0xDB) 0x0cdb0054 */ > .gdb_bpt_instr = {0x54, 0x00, 0xdb, 0x0c}, > }; > diff --git a/arch/microblaze/kernel/kgdb.c b/arch/microblaze/kernel/kgdb.c > index 6366f69d118e..130cd0f064ce 100644 > --- a/arch/microblaze/kernel/kgdb.c > +++ b/arch/microblaze/kernel/kgdb.c > @@ -143,7 +143,7 @@ void kgdb_arch_exit(void) > /* > * Global data > */ > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > #ifdef __MICROBLAZEEL__ > .gdb_bpt_instr = {0x18, 0x00, 0x0c, 0xba}, /* brki r16, 0x18 */ > #else > diff --git a/arch/mips/kernel/kgdb.c b/arch/mips/kernel/kgdb.c > index 31eff1bec577..edfdc2ec2d16 100644 > --- a/arch/mips/kernel/kgdb.c > +++ b/arch/mips/kernel/kgdb.c > @@ -394,7 +394,7 @@ int kgdb_arch_handle_exception(int vector, int signo, int err_code, > return -1; > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > #ifdef CONFIG_CPU_BIG_ENDIAN > .gdb_bpt_instr = { spec_op << 2, 0x00, 0x00, break_op }, > #else > diff --git a/arch/nios2/kernel/kgdb.c b/arch/nios2/kernel/kgdb.c > index 117859122d1c..37b25f844a2d 100644 > --- a/arch/nios2/kernel/kgdb.c > +++ b/arch/nios2/kernel/kgdb.c > @@ -165,7 +165,7 @@ void kgdb_arch_exit(void) > /* Nothing to do */ > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: trap 30 */ > .gdb_bpt_instr = { 0xba, 0x6f, 0x3b, 0x00 }, > }; > diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c > index 59c578f865aa..bdb588b1d8fb 100644 > --- a/arch/powerpc/kernel/kgdb.c > +++ b/arch/powerpc/kernel/kgdb.c > @@ -477,7 +477,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt) > /* > * Global data > */ > -struct kgdb_arch arch_kgdb_ops; > +const struct kgdb_arch arch_kgdb_ops; > > static int kgdb_not_implemented(struct pt_regs *regs) > { > diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c > index 4f04c6638a4d..a24c48446e98 100644 > --- a/arch/sh/kernel/kgdb.c > +++ b/arch/sh/kernel/kgdb.c > @@ -382,7 +382,7 @@ void kgdb_arch_exit(void) > unregister_die_notifier(&kgdb_notifier); > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: trapa #0x3c */ > #ifdef CONFIG_CPU_LITTLE_ENDIAN > .gdb_bpt_instr = { 0x3c, 0xc3 }, > diff --git a/arch/sparc/kernel/kgdb_32.c b/arch/sparc/kernel/kgdb_32.c > index 639c8e54530a..7580775a14b9 100644 > --- a/arch/sparc/kernel/kgdb_32.c > +++ b/arch/sparc/kernel/kgdb_32.c > @@ -166,7 +166,7 @@ void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip) > regs->npc = regs->pc + 4; > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: ta 0x7d */ > .gdb_bpt_instr = { 0x91, 0xd0, 0x20, 0x7d }, > }; > diff --git a/arch/sparc/kernel/kgdb_64.c b/arch/sparc/kernel/kgdb_64.c > index a68bbddbdba4..5d6c2d287e85 100644 > --- a/arch/sparc/kernel/kgdb_64.c > +++ b/arch/sparc/kernel/kgdb_64.c > @@ -195,7 +195,7 @@ void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip) > regs->tnpc = regs->tpc + 4; > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: ta 0x72 */ > .gdb_bpt_instr = { 0x91, 0xd0, 0x20, 0x72 }, > }; > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c > index 8e36f249646e..e7effc02f13c 100644 > --- a/arch/x86/kernel/kgdb.c > +++ b/arch/x86/kernel/kgdb.c > @@ -804,7 +804,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt) > (char *)bpt->saved_instr, BREAK_INSTR_SIZE); > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: */ > .gdb_bpt_instr = { 0xcc }, > .flags = KGDB_HW_BREAKPOINT, > diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h > index e465bb15912d..3bf313311cca 100644 > --- a/include/linux/kgdb.h > +++ b/include/linux/kgdb.h > @@ -281,7 +281,7 @@ struct kgdb_io { > int is_console; > }; > > -extern struct kgdb_arch arch_kgdb_ops; > +extern const struct kgdb_arch arch_kgdb_ops; > > extern unsigned long kgdb_arch_pc(int exception, struct pt_regs *regs); > > -- > 2.13.3 >