Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp98000imu; Wed, 19 Dec 2018 14:23:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJnzw/2jOkw0/Ywub/ke4IaifsEUS2+JGecUBI0rHWbolqejl9tRVE39JpjIUcIxhUbycn X-Received: by 2002:a62:9657:: with SMTP id c84mr22695103pfe.77.1545258181537; Wed, 19 Dec 2018 14:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545258181; cv=none; d=google.com; s=arc-20160816; b=blHldVp7SMoW9nBQPA9AOmsVOyRRKTSmHUnwT8VYibFZlvwu1k7W1msjTl7WCjOF+B w33pAF7TeokH+g0AX219HZYe33LTpZm3VvF1enMGoMCJOnxi8WelQGs0d+UOFAVk2xsN j+rluNghVbBYOWAj7v3F551VuH5EPh/oRL6d1cS29ulJojlCwgwfPbgQSAAR1YyuA+2q VX/pvMyK5lWFXICZ7y2eL7m0QYnNwYVrbNYgalNXDiuAAui1RJ1lC5oSQwYgT2O01jsY zJXtrQQhNllitK2bb8d/11EOn0cfqD+JE5/hvWEEwGrGWg6w/R1AE5hppjb4H/2O+e4P EOwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :reply-to:references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zzEjOKOluUUWksw+oXnin6HXgBufUkueAJaYjC1prj4=; b=BG5oquzPWkMAHFjmuuKaucuxfphLU3BSOe7liT2lZPxzYN7es2567dZUPKB3j8gYJo R6c/uJt9xQH0pWKkXfHCKuh1xkoo8IAIGtOZ8h0zVLRm5DQhbKONcz/gCgCb1WUM9En5 w6txGWqt6ZA7tWChsIAho1N96SSek/BZixLiWuRkW1LGxcWwtdw093NzrkfTJ3894aqT yrkjyDlgtU9bomHlTCFN2uisgD9xz6MenVYF3sNFVcnyeOx9z4zeZODwzIkK112H8Xyh +w5RRYILzc0fTHPvPhUIrxLg5A0aeMPnh4f46s3vFvevRKt1O+p/TmT0trW+S/FN2QjL +0Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CWCHozxt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o38si14097520pgb.423.2018.12.19.14.22.45; Wed, 19 Dec 2018 14:23:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CWCHozxt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730496AbeLSVeK (ORCPT + 99 others); Wed, 19 Dec 2018 16:34:10 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:39594 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727387AbeLSVeI (ORCPT ); Wed, 19 Dec 2018 16:34:08 -0500 Received: by mail-lf1-f66.google.com with SMTP id n18so16144069lfh.6; Wed, 19 Dec 2018 13:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=zzEjOKOluUUWksw+oXnin6HXgBufUkueAJaYjC1prj4=; b=CWCHozxtXPaF/R34zIBV9kgAuN1gg0PddkrPC5aWleCfLISFSDUnCKYlt1SLfa1Qdf AbBcVlgs7IbX/SocNOSs7TJQFHB47Mb19vHQatLapdRgx2CO4a1kc145mUHuA0wziXHH QzZ8yM8QB4lZEUShcVat6wzXvLInx64kvRel1qGAK2FWOTDIZ18UCt14KqSiQ4ShML9x rAO14BDpxcuPoIQYRNZAzrNtOpMAw7VGp3iOilzQ4tI6o+kS0TZkiyLu0KCkKArZ5UO2 dPjUBiO0nyOIiEfyvkENuq9RLsdpeA4AjYW6bWLilccCTnnGGCpqqA/Quth/AjuruGh3 tVQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=zzEjOKOluUUWksw+oXnin6HXgBufUkueAJaYjC1prj4=; b=VWFcHf4RsMUVltkbNBhNHcW9MnkRscPYXj6bUXP/ExmFzmA98FKiKxb90z4AxWRWGf FjxcFKUd7EV5RVkJaTal0VPQSvz+O5qwaOd71NrlzPSrKn700K7gXqXx0F/+tCAueuMY 92B0tClBZ3+yZLtEGbkoOSIZezajWND/9HpTSPm1zzVmdUKa+dlAnsorEzvc9yebuYw4 VA7R6Gssn9OhP89TqArC+PT6i6ajJVlB/zFfi4llB3nPhJ6BHRCjSaI+6th8CnIVVQqi 45HngDizBY5UehcrSiTeSDHspGGldsn+lnZEjKxvd6X1Cg0shpF9CzIyyJVUdMIYmrqa AyiQ== X-Gm-Message-State: AA+aEWaFqcJj2DNVDGRSqPxekW9ZIpmBnpL97kHg3Knns/I28h7FdKRm ObbXfdAZKqDh0/1fKDQrU/dLje6pQ1A= X-Received: by 2002:a19:6514:: with SMTP id z20mr6123044lfb.31.1545255246483; Wed, 19 Dec 2018 13:34:06 -0800 (PST) Received: from localhost.localdomain (dmhwpt3bffxn8z3-j6k-4.rev.dnainternet.fi. [2001:14bb:51:a4c8:5c24:24d7:ca5f:e7d2]) by smtp.gmail.com with ESMTPSA id v64sm3996867lfa.48.2018.12.19.13.34.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Dec 2018 13:34:05 -0800 (PST) From: Igor Stoppa X-Google-Original-From: Igor Stoppa To: Andy Lutomirski , Matthew Wilcox , Peter Zijlstra , Dave Hansen , Mimi Zohar Cc: igor.stoppa@huawei.com, Nadav Amit , Kees Cook , linux-integrity@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] x86_64: memset_user() Date: Wed, 19 Dec 2018 23:33:27 +0200 Message-Id: <20181219213338.26619-2-igor.stoppa@huawei.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181219213338.26619-1-igor.stoppa@huawei.com> References: <20181219213338.26619-1-igor.stoppa@huawei.com> Reply-To: Igor Stoppa MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Create x86_64 specific version of memset for user space, based on clear_user(). This will be used for implementing wr_memset() in the __wr_after_init scenario, where write-rare variables have an alternate mapping for writing. Signed-off-by: Igor Stoppa CC: Andy Lutomirski CC: Nadav Amit CC: Matthew Wilcox CC: Peter Zijlstra CC: Kees Cook CC: Dave Hansen CC: Mimi Zohar CC: linux-integrity@vger.kernel.org CC: kernel-hardening@lists.openwall.com CC: linux-mm@kvack.org CC: linux-kernel@vger.kernel.org --- arch/x86/include/asm/uaccess_64.h | 6 ++++ arch/x86/lib/usercopy_64.c | 54 +++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) diff --git a/arch/x86/include/asm/uaccess_64.h b/arch/x86/include/asm/uaccess_64.h index a9d637bc301d..f194bfce4866 100644 --- a/arch/x86/include/asm/uaccess_64.h +++ b/arch/x86/include/asm/uaccess_64.h @@ -213,4 +213,10 @@ copy_user_handle_tail(char *to, char *from, unsigned len); unsigned long mcsafe_handle_tail(char *to, char *from, unsigned len); +unsigned long __must_check +memset_user(void __user *mem, int c, unsigned long len); + +unsigned long __must_check +__memset_user(void __user *mem, int c, unsigned long len); + #endif /* _ASM_X86_UACCESS_64_H */ diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c index 1bd837cdc4b1..84f8f8a20b30 100644 --- a/arch/x86/lib/usercopy_64.c +++ b/arch/x86/lib/usercopy_64.c @@ -9,6 +9,60 @@ #include #include +/* + * Memset Userspace + */ + +unsigned long __memset_user(void __user *addr, int c, unsigned long size) +{ + long __d0; + unsigned long pattern = 0; + int i; + + for (i = 0; i < 8; i++) + pattern = (pattern << 8) | (0xFF & c); + might_fault(); + /* no memory constraint: gcc doesn't know about this memory */ + stac(); + asm volatile( + " movq %[val], %%rdx\n" + " testq %[size8],%[size8]\n" + " jz 4f\n" + "0: mov %%rdx,(%[dst])\n" + " addq $8,%[dst]\n" + " decl %%ecx ; jnz 0b\n" + "4: movq %[size1],%%rcx\n" + " testl %%ecx,%%ecx\n" + " jz 2f\n" + "1: movb %%dl,(%[dst])\n" + " incq %[dst]\n" + " decl %%ecx ; jnz 1b\n" + "2:\n" + ".section .fixup,\"ax\"\n" + "3: lea 0(%[size1],%[size8],8),%[size8]\n" + " jmp 2b\n" + ".previous\n" + _ASM_EXTABLE_UA(0b, 3b) + _ASM_EXTABLE_UA(1b, 2b) + : [size8] "=&c"(size), [dst] "=&D" (__d0) + : [size1] "r"(size & 7), "[size8]" (size / 8), "[dst]"(addr), + [val] "ri"(pattern) + : "rdx"); + + clac(); + return size; +} +EXPORT_SYMBOL(__memset_user); + +unsigned long memset_user(void __user *to, int c, unsigned long n) +{ + if (access_ok(VERIFY_WRITE, to, n)) + return __memset_user(to, c, n); + return n; +} +EXPORT_SYMBOL(memset_user); + + /* * Zero Userspace */ -- 2.19.1