Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 19 Dec 2018 22:41:38 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     Shayenne Moura <shayenneluzmoura@gmail.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str
Message-ID: <20181219214138.hp4xos7ozlgmnzaz@earth.universe>
References: <cover.1545254191.git.shayenneluzmoura@gmail.com>
 <fcf15d6f35c9e8e3fcc1136e55a0fa3d4fccdf57.1545254191.git.shayenneluzmoura@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="czgalbrsb2hhfpv5"
Content-Disposition: inline
In-Reply-To: <fcf15d6f35c9e8e3fcc1136e55a0fa3d4fccdf57.1545254191.git.shayenneluzmoura@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--czgalbrsb2hhfpv5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

Tomi is neither in To, nor in Cc of this patch?

On Wed, Dec 19, 2018 at 07:22:04PM -0200, Shayenne Moura wrote:
> This patch adjust the print string of drm_display_mode object
> to remove drm_mode_object dependency in omapdrm files.
>=20
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++-------
>  drivers/gpu/drm/omapdrm/omap_crtc.c      | 8 ++------
>  2 files changed, 4 insertions(+), 13 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/o=
mapdrm/omap_connector.c
> index b81302c4bf9e..874d8f3cbff6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -305,14 +305,9 @@ static int omap_connector_mode_valid(struct drm_conn=
ector *connector,
>  	drm_mode_destroy(dev, new_mode);
> =20
>  done:
> -	DBG("connector: mode %s: "
> -			"%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> +	DBG("connector: mode %s: " DRM_MODE_FMT,
>  			(ret =3D=3D MODE_OK) ? "valid" : "invalid",
> -			mode->base.id, mode->name, mode->vrefresh, mode->clock,
> -			mode->hdisplay, mode->hsync_start,
> -			mode->hsync_end, mode->htotal,
> -			mode->vdisplay, mode->vsync_start,
> -			mode->vsync_end, mode->vtotal, mode->type, mode->flags);
> +			DRM_MODE_ARG(mode));
> =20
>  	return ret;
>  }
> diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdr=
m/omap_crtc.c
> index caffc547ef97..40acf4ce7c9f 100644
> --- a/drivers/gpu/drm/omapdrm/omap_crtc.c
> +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
> @@ -427,12 +427,8 @@ static void omap_crtc_mode_set_nofb(struct drm_crtc =
*crtc)
>  	struct omap_crtc *omap_crtc =3D to_omap_crtc(crtc);
>  	struct drm_display_mode *mode =3D &crtc->state->adjusted_mode;
> =20
> -	DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> -	    omap_crtc->name, mode->base.id, mode->name,
> -	    mode->vrefresh, mode->clock,
> -	    mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
> -	    mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
> -	    mode->type, mode->flags);
> +	DBG("%s: set mode: " DRM_MODE_FMT,
> +	    omap_crtc->name, DRM_MODE_ARG(mode));
> =20
>  	drm_display_mode_to_videomode(mode, &omap_crtc->vm);
>  }
> --=20
> 2.17.1
>=20
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--czgalbrsb2hhfpv5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlwauwcACgkQ2O7X88g7
+pqULg/8C4gQ7GUZMIyC25wjrf/BTPzRAxrmLVnFDVxC7HGoXcTDIRluWqjxMuCL
5K+UqDFBstzUZTsD21mowlAabwUNpSpBDCfl9ls7dlCsVjaw5cSm1/ImI//N10Oj
HHa/4NwfU24q4zb7NrIsuXEGhelY8n7jAiUOW8m4xKNmuGDkFAeLx8DaUk3bs7pc
XSpgkh2+cLFdQUuqsbpfyDXP8VcXTLrjo6Nh+pT/+F8z90mvO3PZ1gwhCQ2On8Sb
PkZwE0rY2g+hCrLGH+cunFmJEANTT2rz7v1f2EfqLTdrgS6VnfoWKV3V9eZI2c93
KBeQA4C48pO4oVD7gkF4XarhM7mroW8BTt/gEUJR7UXVR1iRVfhn6bniUlqXhf+Z
zJ/CM5QhlzP3yJ4ECYDZdsYJV1dKgHG+/SZzvpyt+jt6y6mHvgG3t6Zd8WaSBhh8
Dj1UTJ3hqiwfJnP5guEvjxSyaEtryFS7VxXT4ReSqKpjz1YCHwKJlVWiNVk/eZYD
lok4girWmlHRsQXw9alVXljGM3xAq+nmHOzRFqFwtUyr1VcKbjFvNEIarbK2RrKH
nezKkKVRTMsEE5/w3s/EbW20wzEfblQQC7qF2i9+mCVmiEcJiMkox1frRftRdmEN
XNvFHxJeEx7CvlZLHoK4AoNVhQ+M3RPOQHDTiI5sIpfhNXUuk9U=
=usqI
-----END PGP SIGNATURE-----

--czgalbrsb2hhfpv5--